Cosmetic changes

JuliaLang · Nov 16, 2022 · 8eff5d1 · 8eff5d1
1 parent 717067c
commit 8eff5d1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 10 deletions.
diff --git a/src/llvm-demote-float16.cpp b/src/llvm-demote-float16.cpp
@@ -67,7 +67,7 @@ bool have_fp16(Function &caller) {
     Attribute FSAttr = caller.getFnAttribute("target-features");
     StringRef FS =
         FSAttr.isValid() ? FSAttr.getValueAsString() : jl_ExecutionEngine->getTargetFeatureString();
-#if defined _CPU_AARCH64_
+#if defined(_CPU_AARCH64_)
     if (FS.find("+fp16fml") != llvm::StringRef::npos || FS.find("+fullfp16") != llvm::StringRef::npos){
         return true;
     }
@@ -83,16 +83,9 @@ static bool demoteFloat16(Function &F)
 {
     if (have_fp16(F))
         return false;
+
     auto &ctx = F.getContext();
     auto T_float32 = Type::getFloatTy(ctx);
-
-
-    // auto feat_string = TM->getTargetFeatureString();
-    //TODO: change this check to something else pending decision on
-    // https://github.com/JuliaLang/julia/pull/43085#discussion_r788197603
-    // if(feat_string.find("+fp16fml") == llvm::StringRef::npos||feat_string.find("+fullfp16") == llvm::StringRef::npos){
-    //     return false;
-    // }
     SmallVector<Instruction *, 0> erase;
     for (auto &BB : F) {
         for (auto &I : BB) {

diff --git a/src/llvm-multiversioning.cpp b/src/llvm-multiversioning.cpp
@@ -47,7 +47,6 @@ extern Optional<bool> always_have_fma(Function&);
 
 extern Optional<bool> always_have_fp16();
 
-
 namespace {
 constexpr uint32_t clone_mask =
     JL_TARGET_CLONE_LOOP | JL_TARGET_CLONE_SIMD | JL_TARGET_CLONE_MATH | JL_TARGET_CLONE_CPU;