-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add LLVM patch to correctly recognise ICC17 as GCC compatible. (#20266)
- Loading branch information
Showing
2 changed files
with
36 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
From eca8aa608d962e09ea9710670f1c412f608a6f12 Mon Sep 17 00:00:00 2001 | ||
From: Yichao Yu <yyc1992@gmail.com> | ||
Date: Thu, 26 Jan 2017 23:50:18 +0000 | ||
Subject: [PATCH] CMake is funky on detecting Intel 17 as GCC compatible. | ||
|
||
Summary: This adds a fallback in case that the Intel compiler is failed to be detected correctly. | ||
|
||
Reviewers: chapuni | ||
|
||
Reviewed By: chapuni | ||
|
||
Subscribers: llvm-commits, mgorny | ||
|
||
Differential Revision: https://reviews.llvm.org/D27610 | ||
|
||
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@293230 91177308-0d34-0410-b5e6-96231b3b80d8 | ||
--- | ||
cmake/modules/DetermineGCCCompatible.cmake | 2 ++ | ||
1 file changed, 2 insertions(+) | ||
|
||
diff --git a/cmake/modules/DetermineGCCCompatible.cmake b/cmake/modules/DetermineGCCCompatible.cmake | ||
index 1bf15fcba72..1369ebe9d0e 100644 | ||
--- a/cmake/modules/DetermineGCCCompatible.cmake | ||
+++ b/cmake/modules/DetermineGCCCompatible.cmake | ||
@@ -7,5 +7,7 @@ if(NOT DEFINED LLVM_COMPILER_IS_GCC_COMPATIBLE) | ||
set(LLVM_COMPILER_IS_GCC_COMPATIBLE OFF) | ||
elseif( "${CMAKE_CXX_COMPILER_ID}" MATCHES "Clang" ) | ||
set(LLVM_COMPILER_IS_GCC_COMPATIBLE ON) | ||
+ elseif( "${CMAKE_CXX_COMPILER_ID}" MATCHES "Intel" ) | ||
+ set(LLVM_COMPILER_IS_GCC_COMPATIBLE ON) | ||
endif() | ||
endif() | ||
-- | ||
2.11.0 | ||
|
a087c38
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Executing the daily benchmark build, I will reply here when finished:
@nanosoldier
runbenchmarks(ALL, isdaily = true)
a087c38
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something went wrong when running your job:
Logs and partial data can be found here
cc @jrevels
a087c38
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JeffBezanson @vtjnash This looks like a something in inference/subtype.c : https://raw.githubusercontent.com/JuliaCI/BaseBenchmarkReports/203b5f4a8efaa25a27180a7bb0b2d1f1c4a66546/daily_2017_1_29/logs/a087c38ed851d81301591af0b91d6adc42218074_primary.err