Skip to content

Commit

Permalink
Merge pull request #436 from JuliaLang/aa/disable-oa
Browse files Browse the repository at this point in the history
Temporarily disable the OffsetArrays tests for 0.7
  • Loading branch information
ararslan authored Dec 21, 2017
2 parents 7a64c3f + 25515c1 commit afee752
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 7 deletions.
6 changes: 4 additions & 2 deletions src/Compat.jl
Original file line number Diff line number Diff line change
Expand Up @@ -775,8 +775,10 @@ if VERSION < v"0.7.0-DEV.2655"
export eigs, svds
end
elseif VERSION < v"0.7.0-DEV.3019"
import IterativeEigenSolvers
const IterativeEigensolvers = IterativeEigenSolvers
@eval module IterativeEigensolvers
using IterativeEigenSolvers: eigs, svds
export eigs, svds
end
else
import IterativeEigensolvers
end
Expand Down
15 changes: 10 additions & 5 deletions test/runtests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -630,11 +630,16 @@ using Compat: StringVector
@test String(fill!(StringVector(5), 0x61)) == "aaaaa"

# collect
using OffsetArrays
a = OffsetArray(1:3, -1:1)
b = Compat.collect(a)
@test indices(b) === (Base.OneTo(3),)
@test b == [1,2,3]
if VERSION < v"0.7.0-"
# Note: This is disabled on 0.7, since the Compat.collect functionality is only
# applicable on 0.5, and OffsetArrays currently has some incompatibilities with
# 0.7. This can be reenabled later if needed.
using OffsetArrays
a = OffsetArray(1:3, -1:1)
b = Compat.collect(a)
@test indices(b) === (Base.OneTo(3),)
@test b == [1,2,3]
end

# PR 22064
module Test22064
Expand Down

0 comments on commit afee752

Please sign in to comment.