Skip to content

Commit

Permalink
Fix a few naming conflicts in LinAlg/BLAS. Fixes #14268.
Browse files Browse the repository at this point in the history
  • Loading branch information
andreasnoack committed Dec 8, 2015
1 parent 55fd7b1 commit befbcec
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
1 change: 1 addition & 0 deletions base/linalg.jl
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,7 @@ include("linalg/exceptions.jl")
include("linalg/generic.jl")

include("linalg/blas.jl")
import .BLAS: gemv! # consider renaming gemv! in matmul
include("linalg/matmul.jl")
include("linalg/lapack.jl")

Expand Down
4 changes: 1 addition & 3 deletions base/linalg/blas.jl
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,13 @@

module BLAS

import ..axpy!
import Base: copy!, blasfunc
import Base.LinAlg: axpy!, dot

This comment has been minimized.

Copy link
@marius311

marius311 Apr 18, 2017

Contributor

@andreasnoack, I think the right solution to #11067 (comment) actually is that Base.LinAlg.dot should not be imported here. Figured I'd just ask here if that seems right to you? I can submit a PR if so.

This comment has been minimized.

Copy link
@andreasnoack

andreasnoack Apr 18, 2017

Author Member

I'm not sure. You a probably right that this change was what made the dot work for matrices but that wasn't intentional. I think it is too surprising with too different dots in Base so in my opinion, it is better to restrict the BLAS wrapper and require that people reshape before calling it.

This comment has been minimized.

Copy link
@marius311

marius311 Apr 19, 2017

Contributor

The issue with that solution was that it then breaks vecdot(Matrix,Matrix) which just calls the BLAS function as is, and I wasn't sure the implications of changing how vecdot works to fix that. Do you think that'd still be the better way?

This comment has been minimized.

Copy link
@andreasnoack

andreasnoack Apr 19, 2017

Author Member

Yes. If it breaks vecdot then vecdot should just be adjusted. It is probably a minor change.


export
# Level 1
asum,
axpy!,
blascopy!,
dot,
dotc,
dotu,
scal!,
Expand Down

0 comments on commit befbcec

Please sign in to comment.