Skip to content

Commit

Permalink
this test is no longer broken, presumably due to either the varargs o…
Browse files Browse the repository at this point in the history
…r tuple getfield constant prop fixes optimizations
  • Loading branch information
jrevels committed Apr 30, 2018
1 parent fc89723 commit efc42a4
Showing 1 changed file with 1 addition and 10 deletions.
11 changes: 1 addition & 10 deletions stdlib/SparseArrays/test/higherorderfns.jl
Original file line number Diff line number Diff line change
Expand Up @@ -266,16 +266,7 @@ end
# --> test broadcast! entry point / not zero-preserving op
fQ = broadcast(f, fX, fY, fZ); Q = sparse(fQ)
broadcast!(f, Q, X, Y, Z); Q = sparse(fQ) # warmup for @allocated
@test_broken (@allocated broadcast!(f, Q, X, Y, Z)) == 0
broadcast!(f, Q, X, Y, Z); Q = sparse(fQ) # warmup for @allocated
@test (@allocated broadcast!(f, Q, X, Y, Z)) <= 16
# the preceding test allocates 16 bytes in the entry point for broadcast!, but
# none of the earlier tests of the same code path allocate. no allocation shows
# up with --track-allocation=user. allocation shows up on the first line of the
# entry point for broadcast! with --track-allocation=all, but that first line
# almost certainly should not allocate. so not certain what's going on.
# additional info: occurs for broadcast!(f, Z, X) for Z and X of different
# shape, but not for Z and X of the same shape.
@test (@allocated broadcast!(f, Q, X, Y, Z)) == 0
@test broadcast!(f, Q, X, Y, Z) == sparse(broadcast!(f, fQ, fX, fY, fZ))
# --> test shape checks for both broadcast and broadcast! entry points
# TODO strengthen this test, avoiding dependence on checking whether
Expand Down

0 comments on commit efc42a4

Please sign in to comment.