Fix #20409: rank for sparse matrices.

JuliaLang · Dec 17, 2018 · f229e1f · f229e1f
1 parent 01fe7c2
commit f229e1f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/stdlib/SuiteSparse/src/spqr.jl b/stdlib/SuiteSparse/src/spqr.jl
@@ -346,6 +346,7 @@ _ret_size(F::QRSparse, b::AbstractVector) = (size(F, 2),)
 _ret_size(F::QRSparse, B::AbstractMatrix) = (size(F, 2), size(B, 2))
 
 LinearAlgebra.rank(F::QRSparse) = reduce(max, view(F.R.rowval, 1:nnz(F.R)), init = eltype(F.R.rowval)(0))
+LinearAlgebra.rank(S::SparseMatrixCSC) = rank(qr(S))
 
 function (\)(F::QRSparse{T}, B::VecOrMat{Complex{T}}) where T<:LinearAlgebra.BlasReal
 # |z1|z3|  reinterpret  |x1|x2|x3|x4|  transpose  |x1|y1|  reshape  |x1|y1|x3|y3|

diff --git a/stdlib/SuiteSparse/test/spqr.jl b/stdlib/SuiteSparse/test/spqr.jl
@@ -100,8 +100,11 @@ end
 end
 
 @testset "rank" begin
-    @test rank(qr(sprandn(10, 5, 1.0)*sprandn(5, 10, 1.0))) == 5
+    S = sprandn(10, 5, 1.0)*sprandn(5, 10, 1.0)
+    @test rank(qr(S)) == 5
+    @test rank(S) == 5
     @test all(iszero, (rank(qr(spzeros(10, i))) for i in 1:10))
+    @test all(iszero, (rank(spzeros(10, i)) for i in 1:10))
 end
 
 end