Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LLVM segfault in Dict test #27080

Closed
Keno opened this issue May 11, 2018 · 3 comments
Closed

LLVM segfault in Dict test #27080

Keno opened this issue May 11, 2018 · 3 comments
Labels
bug Indicates an unexpected problem or unintended behavior upstream The issue is with an upstream dependency, e.g. LLVM

Comments

@Keno
Copy link
Member

Keno commented May 11, 2018

I've started seeing this while running the dict tests:

julia> A = [1]; B = [2]; C = [3]
1-element Array{Int64,1}:
 3

julia> wkd = WeakKeyDict()
WeakKeyDict{Any,Any} with 0 entries

julia> wkd[A] = 2
2

julia> wkd[B] = 3
3

julia> wkd[C] = 4
4

julia> wkd = filter!( p -> p.first != B, wkd)
Thread 1 received signal SIGSEGV, Segmentation fault.
0x00007f4785c124fc in llvm::MachineInstr::getParent (this=0x0)
    at /home/keno/julia/deps/srccache/llvm-6.0.0/include/llvm/CodeGen/MachineInstr.h:143
143	  MachineBasicBlock* getParent() { return Parent; }
(rr) bt
#0  0x00007f4785c124fc in llvm::MachineInstr::getParent (this=0x0)
    at /home/keno/julia/deps/srccache/llvm-6.0.0/include/llvm/CodeGen/MachineInstr.h:143
#1  0x00007f4785d6a718 in llvm::LiveVariables::runOnBlock (
    this=0x563e97c57630, MBB=0x563e98bfcec0, NumRegs=247)
    at /home/keno/julia/deps/srccache/llvm-6.0.0/lib/CodeGen/LiveVariables.cpp:595
#2  0x00007f4785d6acb6 in llvm::LiveVariables::runOnMachineFunction (
    this=0x563e97c57630, mf=...)
    at /home/keno/julia/deps/srccache/llvm-6.0.0/lib/CodeGen/LiveVariables.cpp:648

Looks to be another AVX512 codegen bug.
@Keno Keno added bug Indicates an unexpected problem or unintended behavior upstream The issue is with an upstream dependency, e.g. LLVM labels May 11, 2018
@Keno
Copy link
Member Author

Keno commented May 11, 2018

Filed as https://bugs.llvm.org/show_bug.cgi?id=37430

@Keno
Copy link
Member Author

Keno commented May 12, 2018

Patch at https://reviews.llvm.org/D46797.

Keno added a commit that referenced this issue May 15, 2018
@Keno
Add patch for #27080
390fbdc
Keno added a commit that referenced this issue May 15, 2018
@Keno
Add patch for #27080
62e9e52
Keno added a commit that referenced this issue May 16, 2018
@Keno
Add patch for #27080
8e459ec
Keno added a commit that referenced this issue May 16, 2018
@Keno
Add patch for #27080
21235bc
Keno added a commit that referenced this issue May 16, 2018
@Keno
Add patch for #27080
ede0e3e
dtzWill pushed a commit to llvm-mirror/llvm that referenced this issue May 18, 2018
@Keno
[X86DomainReassignment] Don't delete IMPLICIT_DEF nodes
4464e8f 
Summary:
We cannot simply delete IMPLICIT_DEF nodes. They may be used
later (e.g. by a PHI) and deleting them will cause later passes (e.g.
LiveVariables) to crash. However, it seems fine to ignore them for
purposes of the domain reassignment (as we do with PHI).

Fixes PR37430
Fixes JuliaLang/julia#27080

Reviewed By: craig.topper
Differential Revision: https://reviews.llvm.org/D46797

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@332680 91177308-0d34-0410-b5e6-96231b3b80d8
jyknight pushed a commit to jyknight/llvm-monorepo that referenced this issue May 18, 2018
@Keno
[X86DomainReassignment] Don't delete IMPLICIT_DEF nodes
3b2acff 
Summary:
We cannot simply delete IMPLICIT_DEF nodes. They may be used
later (e.g. by a PHI) and deleting them will cause later passes (e.g.
LiveVariables) to crash. However, it seems fine to ignore them for
purposes of the domain reassignment (as we do with PHI).

Fixes PR37430
Fixes JuliaLang/julia#27080

Reviewed By: craig.topper
Differential Revision: https://reviews.llvm.org/D46797

llvm-svn=332680
earl pushed a commit to earl/llvm-mirror that referenced this issue May 18, 2018
@Keno
[X86DomainReassignment] Don't delete IMPLICIT_DEF nodes
28833ee 
Summary:
We cannot simply delete IMPLICIT_DEF nodes. They may be used
later (e.g. by a PHI) and deleting them will cause later passes (e.g.
LiveVariables) to crash. However, it seems fine to ignore them for
purposes of the domain reassignment (as we do with PHI).

Fixes PR37430
Fixes JuliaLang/julia#27080

Reviewed By: craig.topper
Differential Revision: https://reviews.llvm.org/D46797

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@332680 91177308-0d34-0410-b5e6-96231b3b80d8
@vchuravy
Copy link
Member

Will be part of the next BB release.

rocm-hcc pushed a commit to ROCm/llvm that referenced this issue May 18, 2018
@Keno @rocm-hcc
[X86DomainReassignment] Don't delete IMPLICIT_DEF nodes
cf5499f 
Summary:
We cannot simply delete IMPLICIT_DEF nodes. They may be used
later (e.g. by a PHI) and deleting them will cause later passes (e.g.
LiveVariables) to crash. However, it seems fine to ignore them for
purposes of the domain reassignment (as we do with PHI).

Fixes PR37430
Fixes JuliaLang/julia#27080

Reviewed By: craig.topper
Differential Revision: https://reviews.llvm.org/D46797

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@332680 91177308-0d34-0410-b5e6-96231b3b80d8
vchuravy added a commit to staticfloat/LLVMBuilder that referenced this issue May 19, 2018
@vchuravy
add patches
b0c17cf 
- JuliaLang/julia#27055
- JuliaLang/julia#27080
- JuliaLang/julia#27032
vchuravy added a commit that referenced this issue May 20, 2018
@vchuravy
bump LLVM BB version and use assertion builds on CI
9a36c83 
Adds patches for:
- #27055
- #27080
- #27032
@vchuravy vchuravy mentioned this issue May 20, 2018
Merged
vchuravy added a commit that referenced this issue May 20, 2018
@vchuravy
bump LLVM BB version and use assertion builds on CI
252e469 
Adds patches for:
- #27055
- #27080
- #27032
vchuravy added a commit that referenced this issue May 22, 2018
@vchuravy
bump LLVM BB version and use assertion builds on CI
3be9714 
Adds patches for:
- #27055
- #27080
- #27032
vchuravy added a commit that referenced this issue May 22, 2018
@vchuravy
bump LLVM BB version and use assertion builds on CI
e5e1b01 
Adds patches for:
- #27055
- #27080
- #27032
vchuravy added a commit that referenced this issue May 23, 2018
@vchuravy
bump LLVM BB version and use assertion builds on CI
2c78a29 
Adds patches for:
- #27055
- #27080
- #27032
vchuravy added a commit that referenced this issue May 24, 2018
@vchuravy
bump LLVM BB version and use assertion builds on CI
55d03bf 
Adds patches for:
- #27055
- #27080
- #27032
jyknight pushed a commit to jyknight/llvm-monorepo that referenced this issue May 29, 2018
@tstellar
Merging r332680:
b0fbcbc 
------------------------------------------------------------------------
r332680 | kfischer | 2018-05-17 17:40:52 -0700 (Thu, 17 May 2018) | 13 lines

[X86DomainReassignment] Don't delete IMPLICIT_DEF nodes

Summary:
We cannot simply delete IMPLICIT_DEF nodes. They may be used
later (e.g. by a PHI) and deleting them will cause later passes (e.g.
LiveVariables) to crash. However, it seems fine to ignore them for
purposes of the domain reassignment (as we do with PHI).

Fixes PR37430
Fixes JuliaLang/julia#27080

Reviewed By: craig.topper
Differential Revision: https://reviews.llvm.org/D46797
------------------------------------------------------------------------

llvm-svn=333469
This was referenced May 31, 2018
Closed
Closed
vchuravy added a commit that referenced this issue Jun 3, 2018
@vchuravy
bump LLVM BB version and use assertion builds on CI
e3af87b 
Adds patches for:
- #27055
- #27080
- #27032
vchuravy added a commit that referenced this issue Jun 7, 2018
@vchuravy
bump LLVM BB version and use assertion builds on CI
a05676c 
Adds patches for:
- #27055
- #27080
- #27032
vchuravy added a commit that referenced this issue Jun 15, 2018
@vchuravy
bump LLVM BB version
bf271b5 
Adds patches for:
- #27055
- #27080
- #27032

furthermore this adds the ability to use assertion builds on CI.
Currently turned of on AppVeyor since we are triggering an assertion
there.
vchuravy pushed a commit that referenced this issue Jun 19, 2018
@JeffBezanson @vchuravy
bump LLVM BB version
1fffd23 
Adds patches for:
- #27055
- #27080
- #27032

furthermore this adds the ability to use assertion builds on CI.
Which is used on OSX and Windows.
vchuravy pushed a commit that referenced this issue Jun 19, 2018
@JeffBezanson @vchuravy
bump LLVM BB version
6f15fff 
Adds patches for:
- #27055
- #27080
- #27032

furthermore this adds the ability to use assertion builds on CI.
Which is used on OSX and Windows.
llvm-git-migration pushed a commit to llvm-git-prototype/llvm that referenced this issue Nov 6, 2018
@tstellar
Merging r332680:
0166ae9 
------------------------------------------------------------------------
r332680 | kfischer | 2018-05-17 17:40:52 -0700 (Thu, 17 May 2018) | 13 lines

[X86DomainReassignment] Don't delete IMPLICIT_DEF nodes

Summary:
We cannot simply delete IMPLICIT_DEF nodes. They may be used
later (e.g. by a PHI) and deleting them will cause later passes (e.g.
LiveVariables) to crash. However, it seems fine to ignore them for
purposes of the domain reassignment (as we do with PHI).

Fixes PR37430
Fixes JuliaLang/julia#27080

Reviewed By: craig.topper
Differential Revision: https://reviews.llvm.org/D46797
------------------------------------------------------------------------

llvm-svn=333469
llvm-git-migration pushed a commit to llvm-git-prototype/llvm that referenced this issue Jan 4, 2019
@tstellar
Merging r332680:
2875d5f 
------------------------------------------------------------------------
r332680 | kfischer | 2018-05-17 17:40:52 -0700 (Thu, 17 May 2018) | 13 lines

[X86DomainReassignment] Don't delete IMPLICIT_DEF nodes

Summary:
We cannot simply delete IMPLICIT_DEF nodes. They may be used
later (e.g. by a PHI) and deleting them will cause later passes (e.g.
LiveVariables) to crash. However, it seems fine to ignore them for
purposes of the domain reassignment (as we do with PHI).

Fixes PR37430
Fixes JuliaLang/julia#27080

Reviewed By: craig.topper
Differential Revision: https://reviews.llvm.org/D46797
------------------------------------------------------------------------

llvm-svn: 333469
ajohnson-uoregon pushed a commit to ajohnson-uoregon/clang-rewrite-only that referenced this issue Jul 17, 2022
@tstellar
Merging r332680:
ce9a32f 
------------------------------------------------------------------------
r332680 | kfischer | 2018-05-17 17:40:52 -0700 (Thu, 17 May 2018) | 13 lines

[X86DomainReassignment] Don't delete IMPLICIT_DEF nodes

Summary:
We cannot simply delete IMPLICIT_DEF nodes. They may be used
later (e.g. by a PHI) and deleting them will cause later passes (e.g.
LiveVariables) to crash. However, it seems fine to ignore them for
purposes of the domain reassignment (as we do with PHI).

Fixes PR37430
Fixes JuliaLang/julia#27080

Reviewed By: craig.topper
Differential Revision: https://reviews.llvm.org/D46797
------------------------------------------------------------------------

llvm-svn: 333469
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Indicates an unexpected problem or unintended behavior upstream The issue is with an upstream dependency, e.g. LLVM
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vchuravy @Keno