Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export Base.nonmissingtype #30657

Closed
juliohm opened this issue Jan 8, 2019 · 4 comments
Closed

Export Base.nonmissingtype #30657

juliohm opened this issue Jan 8, 2019 · 4 comments
Labels
missing data Base.missing and related functionality

Comments

@juliohm
Copy link
Contributor

juliohm commented Jan 8, 2019 •
edited
Loading

It would be nice to have this name documented and exported. It should be used often in stats packages.

The old way with Missings.T is not as descriptive.
@nalimilan nalimilan added the missing data Base.missing and related functionality label Jan 9, 2019
@nalimilan
Copy link
Member

It's not exported because we hoped to offer something more general, like Core.Compiler.typesubtract(T, Missing). But I don't remember what as the problem (except that Core.Compiler.typesubtract cannot be used directly since it's not specialized on purpose -- but another method can be exported).

@tkf tkf mentioned this issue Jan 17, 2019
Closed
@galenlynch
Copy link
Contributor

The function union_poptype in #30549 Is more general (along the lines of typesubstract), and type stable.

@juliohm
Copy link
Contributor Author

juliohm commented Mar 23, 2019

There are plans to export the name in the next minor release of the language?

@nalimilan
Copy link
Member

Maybe make a PR and see how it's received.

juliohm added a commit to juliohm/julia that referenced this issue Mar 30, 2019
@juliohm
Export nonmissingtype
0ad5263 
Fix JuliaLang#30657
@juliohm juliohm mentioned this issue Mar 30, 2019
Closed
JeffBezanson pushed a commit that referenced this issue Aug 15, 2019
@juliohm @JeffBezanson
Export nonmissingtype (#31562)
1e6d5f1 
Fix #30657
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
missing data Base.missing and related functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Export nonmissingtype juliohm/julia
4 participants
@JeffBezanson @nalimilan @juliohm @galenlynch