Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't warn for failed symlink on Windows (just error) #37845

Closed
StefanKarpinski opened this issue Oct 1, 2020 · 0 comments
Closed

don't warn for failed symlink on Windows (just error) #37845

StefanKarpinski opened this issue Oct 1, 2020 · 0 comments
Labels
filesystem Underlying file system and functions that use it system:windows Affects only Windows
Milestone

Comments

@StefanKarpinski
Copy link
Member

StefanKarpinski commented Oct 1, 2020

See JuliaLang/Pkg.jl#2061: in symlink on Windows if the symlink operation fails, we print a warning and the throw an error. This means that even if we catch the warning (when, say, we're just testing to see if we can symlink), we end up printing a warning too. PlatformEngines and Tar were disabling logging to suppress this, but this can cause problems with Julia's CI (this is the root cause of the very annoying #37731 CI failures). There are already PRs to stop disabling logging in both of these places: JuliaLang/Pkg.jl#2062, JuliaIO/Tar.jl#76. However, we should also stop printing that warning and instead include the warning test, if at all, in the error message.

@StefanKarpinski StefanKarpinski added system:windows Affects only Windows filesystem Underlying file system and functions that use it labels Oct 1, 2020
@StefanKarpinski StefanKarpinski added this to the 1.6 features milestone Oct 1, 2020
KristofferC added a commit that referenced this issue Oct 2, 2020
symlink: don't warn on Windows symlink failure (fix #37845)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filesystem Underlying file system and functions that use it system:windows Affects only Windows
Projects
None yet
Development

No branches or pull requests

1 participant