Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loading some functions from precompiled files seems broken #41156

Closed
vtjnash opened this issue Jun 9, 2021 · 1 comment · Fixed by #41277
Closed

Loading some functions from precompiled files seems broken #41156

vtjnash opened this issue Jun 9, 2021 · 1 comment · Fixed by #41277
Labels
regression Regression in behavior compared to a previous version
Milestone
1.7

Comments

@vtjnash
Copy link
Sponsor Member

vtjnash commented Jun 9, 2021 

$ ./julia --warn-overwrite=yes 
               _
   _       _ _(_)_     |  Documentation: https://docs.julialang.org
  (_)     | (_) (_)    |
   _ _   _| |_  __ _   |  Type "?" for help, "]?" for Pkg help.
  | | | | | | |/ _` |  |
  | | |_| | | | (_| |  |  Version 1.7.0-DEV.1297 (2021-06-09)
 _/ |\__'_|_|_|\__'_|  |  Commit f442e4230a* (0 days old master)
|__/                   |

julia> using Missings
WARNING: Method definition (::Missings.PassMissing{F})(Any...) where {F} in module Missings at /home/vtjnash/.julia/packages/Missings/sx5js/src/Missings.jl:192 overwritten on the same line (check for duplicate calls to `include`).
WARNING: Method definition (::Missings.PassMissing{F})(Any) where {F} in module Missings at /home/vtjnash/.julia/packages/Missings/sx5js/src/Missings.jl:184 overwritten on the same line (check for duplicate calls to `include`).

julia> 

$ ./julia --warn-overwrite=yes --compiled-modules=no
               _
   _       _ _(_)_     |  Documentation: https://docs.julialang.org
  (_)     | (_) (_)    |
   _ _   _| |_  __ _   |  Type "?" for help, "]?" for Pkg help.
  | | | | | | |/ _` |  |
  | | |_| | | | (_| |  |  Version 1.7.0-DEV.1297 (2021-06-09)
 _/ |\__'_|_|_|\__'_|  |  Commit f442e4230a* (0 days old master)
|__/                   |

julia> using Missings
@vtjnash vtjnash added regression Regression in behavior compared to a previous version backport 1.7 labels Jun 9, 2021
@JeffBezanson JeffBezanson added this to the 1.7 milestone Jun 9, 2021
@vtjnash vtjnash changed the title Loading some functions from precompiled files seems broken (possible @generated bug?) Loading some functions from precompiled files seems broken Jun 18, 2021
vtjnash added a commit that referenced this issue Jun 18, 2021
@vtjnash
fix handling of MethodTable in precompile files
3343980 
This was not an external method table, it is just a normal variable
binding. This was causing the precompile files to be corrupted, since we
use normal variables that look like this one at
https://github.com/JuliaLang/julia/blob/dc2befcffc7412768097c2a2a6819724a4745aeb/base/compiler/utilities.jl#L139-L140

Fixes #41156
@vtjnash vtjnash mentioned this issue Jun 18, 2021
Merged
@KristofferC KristofferC mentioned this issue Jun 18, 2021
Closed
vtjnash added a commit that referenced this issue Jun 19, 2021
@vtjnash
fix handling of MethodTable in precompile files (#41277)
e3197af 
This was not an external method table, it is just a normal variable
binding. This was causing the precompile files to be corrupted, since we
use normal variables that look like this one at
https://github.com/JuliaLang/julia/blob/dc2befcffc7412768097c2a2a6819724a4745aeb/base/compiler/utilities.jl#L139-L140

Fixes #41156
KristofferC pushed a commit that referenced this issue Jun 26, 2021
@vtjnash @KristofferC
fix handling of MethodTable in precompile files (#41277)
7d75619 
This was not an external method table, it is just a normal variable
binding. This was causing the precompile files to be corrupted, since we
use normal variables that look like this one at
https://github.com/JuliaLang/julia/blob/dc2befcffc7412768097c2a2a6819724a4745aeb/base/compiler/utilities.jl#L139-L140

Fixes #41156

(cherry picked from commit e3197af)
@Seelengrab Seelengrab mentioned this issue Jul 5, 2021
Closed
johanmon pushed a commit to johanmon/julia that referenced this issue Jul 5, 2021
@vtjnash @johanmon
fix handling of MethodTable in precompile files (JuliaLang#41277)
225a3bf 
This was not an external method table, it is just a normal variable
binding. This was causing the precompile files to be corrupted, since we
use normal variables that look like this one at
https://github.com/JuliaLang/julia/blob/dc2befcffc7412768097c2a2a6819724a4745aeb/base/compiler/utilities.jl#L139-L140

Fixes JuliaLang#41156
@guo-yong-zhi
Copy link

Please see #40441. It seems relevant.

jessymilare pushed a commit to jessymilare/julia that referenced this issue Sep 11, 2021
@vtjnash @jessymilare
fix handling of MethodTable in precompile files (JuliaLang#41277)
c6fff9e 
This was not an external method table, it is just a normal variable
binding. This was causing the precompile files to be corrupted, since we
use normal variables that look like this one at
https://github.com/JuliaLang/julia/blob/dc2befcffc7412768097c2a2a6819724a4745aeb/base/compiler/utilities.jl#L139-L140

Fixes JuliaLang#41156
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
regression Regression in behavior compared to a previous version
Projects
None yet
Milestone
1.7
Development

Successfully merging a pull request may close this issue.

fix handling of MethodTable in precompile files JuliaLang/julia
4 participants
@vtjnash @JeffBezanson @KristofferC @guo-yong-zhi