Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edit(::Method) doesn't work in 1.7-beta2 #41408

Closed
rashidrafeek opened this issue Jun 29, 2021 · 3 comments · Fixed by #41414
Closed

edit(::Method) doesn't work in 1.7-beta2 #41408

rashidrafeek opened this issue Jun 29, 2021 · 3 comments · Fixed by #41414
Labels
regression Regression in behavior compared to a previous version
Milestone

Comments

@rashidrafeek
Copy link
Contributor

rashidrafeek commented Jun 29, 2021

For eg,

edit(methods(match).ms[1])

doesn't work in 1.7-beta2 and it returns nothing.

This was due to #39481 which changed edit(::Function) to return the method list instead of showing an error. It suggests using a shortcut, num-(ctrl-q) to go to the specific method from the list. But this doesn't seem to work for me (Maybe I am not doing it correctly, but didn't find any docs regarding this shortcut). Even though, I think the above code block not working was not intended in that PR.

@JeffBezanson JeffBezanson added the regression Regression in behavior compared to a previous version label Jun 29, 2021
@JeffBezanson JeffBezanson added this to the 1.7 milestone Jun 29, 2021
@JeffBezanson
Copy link
Sponsor Member

Oops 😬 Thanks, good catch. We need to add an explicit edit(::Method) method now. Would you be willing to make a PR for it?

rashidrafeek added a commit to rashidrafeek/julia that referenced this issue Jun 30, 2021
rashidrafeek added a commit to rashidrafeek/julia that referenced this issue Jun 30, 2021
@rashidrafeek
Copy link
Contributor Author

@JeffBezanson Done :) .

@rashidrafeek
Copy link
Contributor Author

rashidrafeek commented Jun 30, 2021

Just an opinion on #39481. Shouldn't there be an indication on what to do with the method list, when showing a method list. Like telling to use edit(f,id), where id is the index of the method, instead of edit(f). Otherwise it seems like the function is doing something unrelated to the function call.

fredrikekre pushed a commit that referenced this issue Jun 30, 2021
KristofferC pushed a commit that referenced this issue Jun 30, 2021
(cherry picked from commit 71bf608)
johanmon pushed a commit to johanmon/julia that referenced this issue Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression Regression in behavior compared to a previous version
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants