-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
_simplify_include_frames throws bounds error #41566
Comments
Yes this is a bug, thanks for the report.
Perfect, please do. Two separate PRs seems fine. Looking back at this code, I'm not sure why I wrote it as a |
Sorry, quick question: Is there a standard way to develop/test Base code (ideally using Revise.jl)? Normally I would do e.g. |
TBH I haven't done this for a while. But you should be able to build Julia from source and use |
Original issue: JuliaLang/PackageCompiler.jl#517
When using a sysimage,
_simplify_include_frames
throws a bounds error at line 804 becausei
is 0.julia/base/errorshow.jl
Line 804 in d732903
The immediate fix is to move the decrement to the top of the loop and start at
i = length(trace) + 1
. I can make a pull request for this.This still gives really verbose stack traces when using a sysimage. I'd like to take a shot at improving that as well, but perhaps this should be done in a separate issue/pull request since it might require further discussion.
Thanks to @KristofferC for identifying the problem.
The text was updated successfully, but these errors were encountered: