-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build fails on macOS with Xcode 13.0 (but passes with Xcode 12.5.1) #42346
Comments
It is likely you have something broken in your environment. Check |
I don't see anything suspicious. 🙁
Edit: thanks for the quick response! |
|
This seems like an error on our end. If the build doesn't support |
I'm reopening this because I think we need to fix this on our end. |
For what it's worth, this happens to me even with |
@vilterp and, it's worth mentioning, it only started happening to you today, on a build that was working up til yesterday. |
It would be great to bisect this. |
I am not able to reproduce this locally with the following setup:
I tried both with and without @jonas-schulze or @vilterp would you be able to |
The thing is, I am now unable to build commits which I was able to build before. It seems like some state on my system is corrupt, which is preventing the build from succeeding. I tried The only thing I can think of which changed from when it was working to now is that I used to only be building the C source, with Eventually, I made a change to the Julia source (this is all on #42286), and issued Is there some state outside of the julia checkout directory itself which could be corrupted, causing my failed builds? |
There shouldn't be any state outside of the Julia source directory. To be safe, you can try doing e.g. Has anything changed on your system? For example:
For example, Xcode 13 was released on September 20, 2021. If you installed Xcode from the Mac App Store, I think it auto-updates whenever a new version is released. So maybe that's what happened here? |
Hm, maybe it is an XCode update or something. I pulled out an old laptop, and the same commits build just fine on it.
Unblocked for now, thankfully… Thanks for helping look into this! Still mysterious… 🤔 |
If the Julia build is broken on Xcode 13, that is not great... |
Maybe it auto-updated under me. What is the macOS CI running? Will take a look… |
Can't tell from this build what version of xcode/clang is running in CI; not sure where the config lives https://build.julialang.org/#/builders/63/builds/3806 But yeah, maybe it's broken on clang 13 |
Great sleuthing y'all 👍👍 |
On my local machine, with otherwise identical build environments, I can confirm that the build passes with Xcode 12 and fails with Xcode 13. Both of these builds are using the exact same commit of Julia.
The error I get with Xcode 13.0 is the same as others have posted:
Note: the |
$ xcodebuild -version
Xcode 13.0
Build version 13A233
$ git --version
git version 2.30.1 (Apple Git-130)
$ git blame -sl VERSION
^5e8d7edfffbac8a69fad0f901089bbaa97d1043 1) 1.8.0-DEV oh, it was my fault. I did git clone of depth 1. |
The last time I worked on Julia (#41834), everything built just fine. Now that commit is "broken", too. I don't know my version of Clang or Xcode back then but now it's 13:
|
Yeah, based on the comments from @jonas-schulze and @vilterp, I don't think anything changed in Julia. I think the issue is with Xcode 12 versus Xcode 13. |
jl_current_task is not constant after this point in the function, so we split the function so that the compiler won't try to optimize it incorrectly (hoisting the JL_GC_PUSH to the top of the function for example). Fixes #42346
I just hit this but didn't find this issue until after a few hours of head scratching.. |
jl_current_task is not constant after this point in the function, so we split the function so that the compiler won't try to optimize it incorrectly (hoisting the JL_GC_PUSH to the top of the function for example). Fixes #42346
jl_current_task is not constant after this point in the function, so we split the function so that the compiler won't try to optimize it incorrectly (hoisting the JL_GC_PUSH to the top of the function for example). Fixes #42346
jl_current_task is not constant after this point in the function, so we split the function so that the compiler won't try to optimize it incorrectly (hoisting the JL_GC_PUSH to the top of the function for example). Fixes JuliaLang#42346
jl_current_task is not constant after this point in the function, so we split the function so that the compiler won't try to optimize it incorrectly (hoisting the JL_GC_PUSH to the top of the function for example). Fixes JuliaLang#42346
Cloning and building Julia on the current master (5bf1ca5)
leads to
While working on my "old" clone, I encountered the same problem.
make clean
andmake cleanall
didn't fix the issue. I didn't try this on the new clone. I also tried creating aMake.user
containingJULIA_PRECOMPILE=0
, but that didn't work either.I am running macOS 11.5.2 on a 2018 MacBook Pro. From my homebrew Julia installation:
The text was updated successfully, but these errors were encountered: