Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Woodbury and Bunch Kaufman #4638

Closed
ViralBShah opened this issue Oct 26, 2013 · 6 comments
Closed

Woodbury and Bunch Kaufman #4638

ViralBShah opened this issue Oct 26, 2013 · 6 comments
Labels
linear algebra Linear algebra needs decision A decision on this change is needed

Comments

@ViralBShah
Copy link
Member

I wonder if we should move the Woodbury and Bunch Kaufman out of Base into a LinearAlgebra.jl package. There all kinds of other stuff that could potentially be in there, like all the stuff from Golub and Van Loan.

@JeffBezanson
Copy link
Sponsor Member

Let's just leave them in Base unless they are truly not useful.

@jiahao
Copy link
Member

jiahao commented Jan 26, 2014

In #2593, @dmbates wrote:

the description of the \ operator is inaccurate. The Hermitian case uses the BunchKaufman factorization, not the Cholesky factor.

Things have probably changed a lot in the intervening months, but I cannot find any evidence that the BunchKaufman factorization is being used in the linear solver polyalgorithm anymore. In fact, I can't find a single use of BunchKaufman anywhere in the base library other than the bkfact and bkfact! functions which compute and return the factorization.

You can still use BunchKaufman factorizations in linear solvers (via A_ldiv_B!) and compute matrix inverses, but that's pretty much it. These functions wrap LAPACK.sytrs! and LAPACK.hetrs!.

jiahao referenced this issue Jan 26, 2014
@jiahao
Copy link
Member

jiahao commented Jan 26, 2014

Similarly, Woodbury is entirely self-contained and essentially not referenced outside of base/linalg/woodbury.jl.

@timholy
Copy link
Sponsor Member

timholy commented Jan 26, 2014

It's used in Grid, but there's no reason we can't have Grid load a package.

@jiahao
Copy link
Member

jiahao commented Jan 26, 2014

Apologies, BunchKaufman is indeed used in the linear solver exactly as @dmbates wrote. \ on Symmetric and Hermitian matrices call bkfact.

jiahao added a commit that referenced this issue Jan 26, 2014
- Revert change in documentation about use of BunchKaufman in \ (#4638)
- Document return type of sqrtm (Closes #4006)
@jakebolewski
Copy link
Member

Woodbury has been extracted (#10024), BunchKaufman is more useful to have in Base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linear algebra Linear algebra needs decision A decision on this change is needed
Projects
None yet
Development

No branches or pull requests

5 participants