Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unreachable reached in collect #47374

Closed
fredrikekre opened this issue Oct 28, 2022 · 4 comments
Closed

Unreachable reached in collect #47374

fredrikekre opened this issue Oct 28, 2022 · 4 comments

Comments

@fredrikekre
Copy link
Member

Reduced failure in a package to

function value(x)
    [value(i, x) for i in 1:1]
end
function value(i::Int, x)
    return 1.0
end
value(rand(1))

which gives

Unreachable reached at 0x7fbd8c4c4bcd

[10347] signal (4): Illegal instruction
in expression starting at REPL[3]:2
iterate at ./generator.jl:44 [inlined]
collect_to! at ./array.jl:840 [inlined]
collect_to_with_first! at ./array.jl:818 [inlined]
collect at ./array.jl:792 [inlined]
value at ./REPL[1]:2
unknown function (ip: 0x7fbd8c4c4be2)
jl_apply at /home/fredrik/julia-master/src/julia.h:1869 [inlined]
do_call at /home/fredrik/julia-master/src/interpreter.c:126
@fredrikekre
Copy link
Member Author

git bisect points to 6baa9a6 cc @Keno

@Keno
Copy link
Member

Keno commented Oct 28, 2022

Yeah, that commit was likely unsound. Will be undone in #47371.

@Keno
Copy link
Member

Keno commented Oct 28, 2022

Fixed by merge of #47371

@Keno Keno closed this as completed Oct 28, 2022
@KristofferC
Copy link
Member

Can we add a test for this? I'm pretty amazed that this made it through all our tests...

aviatesk added a commit that referenced this issue Nov 24, 2022
So that they can be deleted during the first `compact!`-ion.
This allows us to delete an inlineable and effect-free, but unused call.

This is essentially an alternative of #47305, but doesn't introduce a
problem like #47374.
aviatesk added a commit that referenced this issue Nov 24, 2022
So that they can be deleted during the first `compact!`-ion.
This allows us to delete an inlineable and effect-free, but unused call.

This is essentially an alternative of #47305, but doesn't introduce a
problem like #47374.
aviatesk added a commit that referenced this issue Nov 25, 2022
So that they can be deleted during the first `compact!`-ion.
This allows us to delete an inlineable and effect-free, but unused call.

This is essentially an alternative of #47305, but doesn't introduce a
problem like #47374.
aviatesk added a commit that referenced this issue Nov 25, 2022
So that they can be deleted during the first `compact!`-ion.
This allows us to delete an inlineable and effect-free, but unused call.

This is essentially an alternative of #47305, but doesn't introduce a
problem like #47374.
aviatesk added a commit that referenced this issue Nov 30, 2022
So that they can be deleted during the first `compact!`-ion.
This allows us to delete an inlineable and effect-free, but unused call.

This is essentially an alternative of #47305, but doesn't introduce a
problem like #47374.
aviatesk added a commit that referenced this issue Dec 22, 2022
So that they can be deleted during the first `compact!`-ion.
This allows us to delete an inlineable and effect-free, but unused call.

This is essentially an alternative of #47305, but doesn't introduce a
problem like #47374.
aviatesk added a commit that referenced this issue Dec 22, 2022
So that they can be deleted during the first `compact!`-ion.
This allows us to delete an inlineable and effect-free, but unused call.

This is essentially an alternative of #47305, but doesn't introduce a
problem like #47374.
aviatesk added a commit that referenced this issue Dec 22, 2022
#47689)

So that they can be deleted during the first `compact!`-ion.
This allows us to delete an inlineable and effect-free, but unused call.

This is essentially an alternative of #47305, but doesn't introduce a
problem like #47374.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants