-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build of Julia 1.8.2 has broken #48698
Comments
I wonder if this is somehow related to #48466, since we download an automatically generated archive: julia/stdlib/Statistics.version Line 4 in 8068e44
|
A stable tarball would have helped but in this case I think it is not the gzip algorithm but the fact that this repo changed organization and the tarball seems to reflect this:
The srccache tarball was extracted from |
CC: @KristofferC, this ended up breaking our build unexpectedly. We have a workaround now, but it's a bit hacky. Is there a way to resolve this by putting the Statistics package back where it was expected to be in the 1.8.2 build? |
Moving back JuliaStats/Statistics.jl to JuliaLang/Statistics.jl? The issue with that is that newer versions have hashes generated based on the new location though, no? |
|
Yeah, thanks @fredrikekre, i think that's what i had in mind. that sounds great. thanks! |
We could archive, upload and release an older version in Note: According to #48466 only manually uploaded release packages has a stable hash. An unstable Workaround Detailscurl -L -o with-repo-name.tar.gz https://api.github.com/repos/JuliaStats/Statistics.jl/tarball/61a021bcb330e6c52f2435f2abaffc77875ab6f2
curl -L -o no-repo-name.tar.gz https://github.com/JuliaStats/Statistics.jl/archive/61a021bcb330e6c52f2435f2abaffc77875ab6f2.tar.gz
diff <(tar -tvf with-repo-name.tar.gz | sort) <(tar -tvf no-repo-name.tar.gz | sort) The latter API generates a folder name that does not contain the name of the github organization. output:
|
One quick fix is to update the hash directly. Which versions do we need to fix?
|
I just forked the repo back to JuliaSyntax.jl this should recreate the archives with the correct sha's. |
JuliaSyntax.jl? |
Sorry... thinking about something else while typing... JuliaLang/Statistics.jl https://github.com/JuliaLang/Statistics.jl |
@inkydragon tested this in #48787 so it seems that worked? |
🙏 thank you @vchuravy! 🫶 |
Cache still seems to be poisoned:
while building Julia 1.8.5. |
Is that the only one? Elliot may need to tell https://cache.julialang.org to reload that file from the source manually (the ETag is probably unchanged, since it is from the same commit hash). |
@staticfloat fixed the cache. |
$ git clone https://github.com/JuliaLang/julia $ cd julia $ git checkout v1.8.2 $ make -j
Results in:
So,
Statistics-61a021bcb330e6c52f2435f2abaffc77875ab6f2.tar.gz
has changed somehow where it's being downloaded (?) butdeps/checksums/Statistics-61a021bcb330e6c52f2435f2abaffc77875ab6f2.tar.gz/sha512
has not.The text was updated successfully, but these errors were encountered: