Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sinpi(::Rational{BigInt}) regression #48735

Closed
sostock opened this issue Feb 20, 2023 · 1 comment · Fixed by #50850
Closed

sinpi(::Rational{BigInt}) regression #48735

sostock opened this issue Feb 20, 2023 · 1 comment · Fixed by #50850
Assignees
@oscardssmith
Labels
maths Mathematical functions regression Regression in behavior compared to a previous version
Milestone
1.10

Comments

@sostock
Copy link
Contributor

sostock commented Feb 20, 2023

#41744 broke sinpi(::Rational{BigInt}), which worked in v1.6, v1.8 and v1.9-beta:

Before:

julia> sinpi(big(1//1))
0.0

After #41744:

julia> sinpi(big(1//1))
ERROR: MethodError: no method matching sinpi_kernel(::BigFloat)
[...]
@sostock sostock added the regression Regression in behavior compared to a previous version label Feb 20, 2023
@giordano giordano added the maths Mathematical functions label Feb 20, 2023
@giordano giordano added this to the 1.10 milestone Feb 20, 2023
@sostock
Copy link
Contributor Author

sostock commented Feb 21, 2023

Other Rational types have problems with overflow:

Before:

julia> sinpi(typemax(Int64)//1)
0.0

After:

julia> sinpi(typemin(Int64)//1)
ERROR: OverflowError: 2 * -9223372036854775808 overflowed for type Int64
[...]

@oscardssmith oscardssmith self-assigned this Feb 21, 2023
@sostock sostock mentioned this issue Feb 27, 2023
Merged
@sostock sostock mentioned this issue Jul 31, 2023
Merged
@gbaraldi gbaraldi mentioned this issue Aug 9, 2023
Merged
KristofferC pushed a commit that referenced this issue Aug 14, 2023
@gbaraldi
Remove weird Rational dispatch and add pi functions to list (#50850)
b763728 
Should fix  #48735
IanButterworth pushed a commit that referenced this issue Aug 19, 2023
@gbaraldi @IanButterworth
Remove weird Rational dispatch and add pi functions to list (#50850)
19fdcce 
Should fix  #48735

(cherry picked from commit b763728)
nalimilan pushed a commit that referenced this issue Nov 5, 2023
@gbaraldi @nalimilan
Remove weird Rational dispatch and add pi functions to list (#50850)
a7f5a35 
Should fix  #48735

(cherry picked from commit b763728)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oscardssmith oscardssmith

Labels
maths Mathematical functions regression Regression in behavior compared to a previous version
Projects
None yet
Milestone
1.10
Development

Successfully merging a pull request may close this issue.

Remove weird Rational dispatch and add pi functions to list gbaraldi/julia
3 participants
@giordano @oscardssmith @sostock