-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Julia 1.9.0 freezes in subtyping #49857
Comments
@quinnj bisected this and found the commit that introduces the freeze. Subsequently, this commit fixes the freeze. Unfortunately, there are manymany commits in between. It seems intractable to backport all of them. |
I think my question is where to go from here; the options seem to be 1) try to backport a good chunk of the subtyping changes or 2) revert the 1 commit from 1.9. The tricky part is that the commit that caused the perf regression also fixed #40865, so I guess another question is what do we think is more common/problematic: the original #40865 issue? Or people running into the perf regression we're seeing here? Maybe @vtjnash has a sense for the best path forward here? |
The union explosion is caused by the following MWE: Type{Vector{Union{....}} <: Type{Array{T}} where {T} 280f999 only fixes for `Union{......}` without free `Typevar`. This fast-path makes sure the remaining get fixed. This fast-path fixes the remaining issue with the same pattern.
The union explosion is caused by the following MWE: Type{Vector{Union{....}} <: Type{Array{T}} where {T} 280f999 only fixes for `Union{......}` without free `Typevar`. This fast-path makes sure the remaining get fixed.
This is fixed for 1.9.1 by #49875. |
Reproducer:
This worked on
1.8
and is also fixed onmaster
.The text was updated successfully, but these errors were encountered: