Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using include_dependency with a non-existent file triggers precompilation at every startup #52063

Closed
longqian95 opened this issue Nov 7, 2023 · 2 comments · Fixed by #53286
Closed

Using include_dependency with a non-existent file triggers precompilation at every startup #52063

longqian95 opened this issue Nov 7, 2023 · 2 comments · Fixed by #53286
Labels
good first issue Indicates a good issue for first-time contributors to Julia packages Package management and loading

Comments

@longqian95
Copy link
Contributor

found this issue after v1.9. no problems at v1.4
@vchuravy
Copy link
Member

vchuravy commented Nov 7, 2023

include_dependency should probably error if the file doesn't exist.

@vchuravy vchuravy added packages Package management and loading good first issue Indicates a good issue for first-time contributors to Julia labels Nov 7, 2023
@KristofferC
Copy link
Member

KristofferC commented Nov 7, 2023 •
edited
Loading

Unless you want to recompile something if a file start to existing I guess... But that feels like kind of strange use case. Anyway, at least it shouldn't recompile if the file continues to not exist.

longqian95 added a commit to longqian95/julia that referenced this issue Nov 8, 2023
@longqian95
Raise an error when using include_dependency with non-existent file
cedf9c2 
Since depending on a non-existent file or directory is strange, raise an error instead of silently triggering precompilation.

Fixes JuliaLang#52063
@longqian95 longqian95 mentioned this issue Nov 9, 2023
Closed
fatteneder pushed a commit to fatteneder/julia that referenced this issue Feb 11, 2024
@longqian95 @fatteneder
Raise an error when using include_dependency with non-existent file
e7c5e21 
Since depending on a non-existent file or directory is strange, raise an error instead of silently triggering precompilation.

Fixes JuliaLang#52063
fatteneder pushed a commit to fatteneder/julia that referenced this issue Feb 11, 2024
@longqian95 @fatteneder
Raise an error when using include_dependency with non-existent file
dc15618 
Since depending on a non-existent file or directory is strange, raise an error instead of silently triggering precompilation.

Fixes JuliaLang#52063
@fatteneder fatteneder mentioned this issue Feb 11, 2024
Merged
fatteneder pushed a commit to fatteneder/julia that referenced this issue Feb 20, 2024
@longqian95 @fatteneder
Raise an error when using include_dependency with non-existent file
a484682 
Since depending on a non-existent file or directory is strange, raise an error instead of silently triggering precompilation.

Fixes JuliaLang#52063
fatteneder pushed a commit to fatteneder/julia that referenced this issue Feb 25, 2024
@longqian95 @fatteneder
Raise an error when using include_dependency with non-existent file
e027857 
Since depending on a non-existent file or directory is strange, raise an error instead of silently triggering precompilation.

Fixes JuliaLang#52063
fatteneder pushed a commit to fatteneder/julia that referenced this issue Jun 7, 2024
@longqian95 @fatteneder
Raise an error when using include_dependency with non-existent file
eadb93a 
Since depending on a non-existent file or directory is strange, raise an error instead of silently triggering precompilation.

Fixes JuliaLang#52063
fatteneder pushed a commit to fatteneder/julia that referenced this issue Jun 20, 2024
@longqian95 @fatteneder
Raise an error when using include_dependency with non-existent file
bc3b67c 
Since depending on a non-existent file or directory is strange, raise an error instead of silently triggering precompilation.

Fixes JuliaLang#52063
KristofferC pushed a commit that referenced this issue Jul 23, 2024
@fatteneder @KristofferC
Raise an error when using include_dependency with non-existent file…
3f67b31 
… or directory (#53286)

Replaces #52105
Fixes #52063

There is a question about whether the `ispath & uperm` check should be
moved inside the `_track_dependencies[]` check (like it was in #52105),
which would make it such that any errors are thrown only during
precompilation.

---------

Co-authored-by: Qian Long <longqian95@gmail.com>
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
(cherry picked from commit 71fa11f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Indicates a good issue for first-time contributors to Julia packages Package management and loading
Projects
None yet
Milestone
No milestone
3 participants
@vchuravy @KristofferC @longqian95