Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export jl_write_coverage_data or its equivalent in Julia 1.10+ #52452

Closed
Drvi opened this issue Dec 8, 2023 · 0 comments · Fixed by #52456
Closed

Export jl_write_coverage_data or its equivalent in Julia 1.10+ #52452

Drvi opened this issue Dec 8, 2023 · 0 comments · Fixed by #52456

Comments

@Drvi
Copy link
Contributor

Drvi commented Dec 8, 2023

Since #49600 jl_write_coverage_data is no longer exported, making it inaccessible in Julia 1.10+. We recently started calling it (as ccall(:jl_write_coverage_data, Cvoid, (Ptr{Cvoid},), Base.JLOptions().output_code_coverage)) in our tests since we're using ReTestItems.jl which runs tests in multiple Julia processes in a parallel. Sometimes one of the test-running processes dies (e.g. we kill a worker on timeout or when the machine is getting too close to OOMing), at which point we lose the coverage information from it -- and our mitigation for that is calling jl_write_coverage_data after each test item. This seems to work well on 1.9 but is not currently compatible with 1.10 and onwards.

It would be great to have the option to generate coverage files eagerly on 1.10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant