Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pkg.REPLExt is not safe to load multithreaded #54889

Open
vtjnash opened this issue Jun 22, 2024 · 0 comments · May be fixed by #54890
Open

Pkg.REPLExt is not safe to load multithreaded #54889

vtjnash opened this issue Jun 22, 2024 · 0 comments · May be fixed by #54890
Milestone
1.12

Comments

@vtjnash
Copy link
Sponsor Member

vtjnash commented Jun 22, 2024

Putting this here as a milestone issue for Julia, since Pkg was recently changed to load on a thread, but it defines an __init__ method which is not safe to run on a thread: JuliaLang/Pkg.jl#3933. This __init__ method must be deleted from the Pkg REPLExt module.
@vtjnash vtjnash added this to the 1.12 milestone Jun 22, 2024
@IanButterworth IanButterworth linked a pull request Jun 22, 2024 that will close this issue
Draft
@vtjnash vtjnash mentioned this issue Jun 22, 2024
Merged
vtjnash added a commit that referenced this issue Jun 24, 2024
@vtjnash
#54739-related fixes for loading stdlibs (#54891)
a7fa1e7 
This fixes a couple unconventional issues people encountered and were
able to report as bugs against #54739

Note that due to several bugs in REPLExt itself
(#54889,
#54888), loading the extension
may still crash julia in some circumstances, but that is now a Pkg bug,
and no longer the fault of the loading code.
KristofferC pushed a commit that referenced this issue Jul 23, 2024
@vtjnash @KristofferC
#54739-related fixes for loading stdlibs (#54891)
bddb4ed 
This fixes a couple unconventional issues people encountered and were
able to report as bugs against #54739

Note that due to several bugs in REPLExt itself
(#54889,
#54888), loading the extension
may still crash julia in some circumstances, but that is now a Pkg bug,
and no longer the fault of the loading code.

(cherry picked from commit a7fa1e7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.12
Development

Successfully merging a pull request may close this issue.

REPL: add lock to orchestrate adding repl modes etc. IanButterworth/julia
1 participant
@vtjnash