Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove call to localize_vars from the async macro #8591

Closed
marmarelis opened this issue Oct 6, 2014 · 5 comments
Closed

Remove call to localize_vars from the async macro #8591

marmarelis opened this issue Oct 6, 2014 · 5 comments

Comments

@marmarelis
Copy link
Contributor

I'm working on a parallelized project in Julia and am trying to implement something similar to the sync/async pattern, as shown in the docs in the pmap implementation. This requires the code in the async block to modify some variables in the outer scope, but that isn't currently possible (with async). Discussions in issues such as #7813 seem to be in favor of this change.

@JeffBezanson
Copy link
Member

As a workaround, try @schedule.

@marmarelis
Copy link
Contributor Author

I look at the schedule macro and see it also calls localize_vars. Did you mean the function as opposed to the macro?

Can I submit a pull request for a change like this? This is my first time contributing to a serious project so I'm not very familiar with the procedure.

@pao
Copy link
Member

pao commented Oct 6, 2014

Sure, feel free to submit a pull request. Make sure you cross-reference relevant issues (as you did in the original post above).

JeffBezanson added a commit that referenced this issue Oct 8, 2014
There really needs to be some macro that does this kind of thing without
playing games with your variables.
@JeffBezanson
Copy link
Member

Ok I removed localize_vars from @schedule. Later we can consider whether to remove it from @async as well.

@amitmurthy
Copy link
Contributor

Closed by #19594

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants