Duck type the function in map, reduce, etc. #10314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| filter!(r::Regex, v) = filter!(x->ismatch(r,x), v) | ||
| filter(r::Regex, v) = filter(x->ismatch(r,x), v) | ||
|
|
||
| filter!(r::Regex, d::Dict) = filter!((k,v)->ismatch(r,k),d) |
There was a problem hiding this comment.
Technically this would need a deprecation, since filter on Dicts expects a 2-argument function. Or I guess we could add a call overload for Regex with 2 extra arguments, but that seems too magical since it really only makes sense for this use case.
|
We're green. OK to merge? |
This is motivated by the existence of call-overloading
timholy
force-pushed
the
teh/ducktype_functions2
branch
from
af864f4
to
6cb7d5b
Compare
timholy
added a commit
that referenced
this pull request
Mar 1, 2015
Duck type the function in map, reduce, etc.
|
Oh crap. I'll try to straighten this out. Thanks for catching it. |
|
OK, it looks like it was simply that one file (git managed the conflict by keeping the file). Fixed in 74c71fb. |
|
@timholy Did you have any changes to DArray that might be relevant in https://github.com/JuliaParallel/DistributedArrays.jl? |
timholy
added a commit
to timholy/FastAnonymous.jl
that referenced
this pull request
Apr 3, 2015
This was referenced Apr 30, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacement of #10312 without all the
cs. Seems that if you force-push before reopening the issue, GitHub gets unhappy.