-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple setjmp and longjmp assembly from openlibm headers #10756
Conversation
6a9b1e5
to
be231a6
Compare
be231a6
to
5977562
Compare
+1 for no longer hardcoding paths int the openlibm tree. |
👍 |
I think I'll need to copy over the license header, annoyingly. |
lgtm. i'm not a lawyer, but this doesn't particularly seem like a derived work to me; I think you could take full ownership of these files, rather than copying the license from openlibm. |
ianal either which is why I'd rather be on the safe side, this definitely required referencing that file and ensuring the content matched. |
i was also the original contributor of the relevant code that you would have referenced (JuliaMath/openlibm@3c8738e). |
Ah, good to know. The non-Windows lines come from JuliaMath/openlibm@f0862df, but also aren't strictly speaking necessary for the current uses of these files. |
So, merge as is, or remove non-Windows pieces along with the license headers? |
If no comments otherwise I'll merge as-is in a day or two. |
i was hoping someone else would evaluate the license as well. i don't think anything in that file can really be claimed as copyrightable, but it would be good to get a second opinion too |
@JeffBezanson is our usual closest-thing-to-almost-a-lawyer... |
Also worthy seeing what @AndyGreenwell has to say. |
Bump again. I'm not opposed to taking out the non-Windows pieces here so there's no license ambiguity, but it will make it more annoying to put back together if we migrate these over to openlibm in the future for MSVC compatibility there. |
Decouple setjmp and longjmp assembly from openlibm headers
No description provided.