Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple setjmp and longjmp assembly from openlibm headers #10756

Merged
merged 2 commits into from
Apr 20, 2015

Conversation

tkelman
Copy link
Contributor

@tkelman tkelman commented Apr 6, 2015

No description provided.

@tkelman tkelman force-pushed the tk/asm-no-openlibm branch 6 times, most recently from 6a9b1e5 to be231a6 Compare April 6, 2015 07:41
@tkelman tkelman force-pushed the tk/asm-no-openlibm branch from be231a6 to 5977562 Compare April 6, 2015 08:07
@nalimilan
Copy link
Member

+1 for no longer hardcoding paths int the openlibm tree.

@ViralBShah
Copy link
Member

👍

@tkelman
Copy link
Contributor Author

tkelman commented Apr 6, 2015

I think I'll need to copy over the license header, annoyingly.

@vtjnash
Copy link
Member

vtjnash commented Apr 7, 2015

lgtm.

i'm not a lawyer, but this doesn't particularly seem like a derived work to me; I think you could take full ownership of these files, rather than copying the license from openlibm.

@tkelman
Copy link
Contributor Author

tkelman commented Apr 7, 2015

ianal either which is why I'd rather be on the safe side, this definitely required referencing that file and ensuring the content matched.

@vtjnash
Copy link
Member

vtjnash commented Apr 7, 2015

i was also the original contributor of the relevant code that you would have referenced (JuliaMath/openlibm@3c8738e).

@tkelman
Copy link
Contributor Author

tkelman commented Apr 7, 2015

Ah, good to know. The non-Windows lines come from JuliaMath/openlibm@f0862df, but also aren't strictly speaking necessary for the current uses of these files.

@tkelman tkelman changed the title WIP: Decouple setjmp and longjmp assembly from openlibm headers Decouple setjmp and longjmp assembly from openlibm headers Apr 8, 2015
@tkelman
Copy link
Contributor Author

tkelman commented Apr 14, 2015

So, merge as is, or remove non-Windows pieces along with the license headers?

@tkelman
Copy link
Contributor Author

tkelman commented Apr 16, 2015

If no comments otherwise I'll merge as-is in a day or two.

@vtjnash
Copy link
Member

vtjnash commented Apr 16, 2015

i was hoping someone else would evaluate the license as well. i don't think anything in that file can really be claimed as copyrightable, but it would be good to get a second opinion too

@tkelman
Copy link
Contributor Author

tkelman commented Apr 16, 2015

@JeffBezanson is our usual closest-thing-to-almost-a-lawyer...

@ViralBShah
Copy link
Member

Also worthy seeing what @AndyGreenwell has to say.

@tkelman
Copy link
Contributor Author

tkelman commented Apr 18, 2015

Bump again. I'm not opposed to taking out the non-Windows pieces here so there's no license ambiguity, but it will make it more annoying to put back together if we migrate these over to openlibm in the future for MSVC compatibility there.

tkelman added a commit that referenced this pull request Apr 20, 2015
Decouple setjmp and longjmp assembly from openlibm headers
@tkelman tkelman merged commit 5499882 into master Apr 20, 2015
@tkelman tkelman deleted the tk/asm-no-openlibm branch April 20, 2015 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants