Rename stagedfunction → ＠generated function #10884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ref: comments starting with #7474 (comment) |
|
👍 Thanks!! |
|
👍 |
|
Failures seem to be unrelated connectivity issues. |
|
👍 |
|
Really nice. Did not realize how easy this would be. |
|
Looks like this already needs a rebase? |
This fixes the long-standing name "bug". Note that it only affects surface syntax. Internally, generated functions still use the old language (e.g., Expr(:stagedfunction, ...), isstaged, stagedcache, etc). This adds a temporary deprecation to the `stagedfunction` keyword -- the keyword should be entirely removed before the 0.4 release.
|
Rebased, will merge after CI. |
mbauman
added a commit
that referenced
this pull request
Apr 20, 2015
Rename stagedfunction → ＠generated function
tomasaschan
pushed a commit
to tomasaschan/julia
that referenced
this pull request
Apr 20, 2015
mbauman
pushed a commit
to mbauman/julia
that referenced
this pull request
Jun 6, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the long-standing name "bug". Note that it only affects surface syntax. Internally, generated functions still use the old language (e.g.,
Expr(:stagedfunction, …),isstaged,stagedcache, etc).This adds a temporary deprecation to the
stagedfunctionkeyword -- the keyword should be entirely removed before the 0.4 release.Given that we have an outstanding PR for documentation (#10673), it'd be nice to use it's real name… if this is its real name. It was a long time ago, but I believe this was the preferred naming.
This also enables one-liner
@generatedfunctions, because it's easy.