Change some arguments from T::Type → ::Type{T}
#10989
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of these were likely doing just fine because they got inlined (in which case I think this change is purely cosmetic). And while this may cause more specialized methods to be compiled, I believe that these are cases where we want them to be specialized. That said, I'm unfamiliar with these portions of the codebase (cc @Jutho for concatenation, @tanmaykm for readdlm) and these were purely mechanical changes spurred by JuliaLang#10988 (`ack '::(Data)?Type[^{]' base`). This may help readdlm performance (JuliaLang#10428), but I've done no testing.
mbauman
force-pushed
the
mb/type-isnt-typed
branch
from
4407793
to
a6b7856
Compare
| @@ -38,16 +38,16 @@ function countlines(io::IO, eol::Char) | |||
| nl | |||
| end | |||
|
|
|||
| readdlm(input, T::Type; opts...) = readdlm(input, invalid_dlm, T, '\n'; opts...) | |||
| readdlm(input, dlm::Char, T::Type; opts...) = readdlm(input, dlm, T, '\n'; opts...) | |||
| readdlm{T}(input, ::Type{T}; opts...) = readdlm(input, invalid_dlm, T, '\n'; opts...) | |||
There was a problem hiding this comment.
A 1-line function like this that just passes its arguments through is a perfect example of a case where you don't need to specialize on every value of T.
There was a problem hiding this comment.
Is it treated differently upon inlining? I was under the (perhaps misguided) impression that this was also the better style in general. I'll re-examine this PR with more consideration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of these were likely doing just fine because they got inlined (in which case I think this change is purely cosmetic). And while this may cause more specialized methods to be compiled, I believe that these are cases where we want them to be specialized. That said, I'm unfamiliar with these portions of the codebase (cc @Jutho for concatenation, @tanmaykm for readdlm) and these were purely mechanical changes spurred by #10988 (
ack '::(Data)?Type[^{]' base).This may help readdlm performance (#10428), but I've done no testing.