-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc linalg tests #12870
Misc linalg tests #12870
Conversation
We have an unrelated OOM failure and something I don't understand on OSX. Weirdly enough, I ran this locally on OSX and it's fine? I can reproduce on |
In the process of hunting I realized we were running the tests on the same matrices multiple times for no reason. |
And running it multiple times was causing the failure? |
I honestly have no idea. When I switched the random seeds, it went away. When I didn't preset a seed, it went away. I think this situation the linalg tests are in right now where we run with a specific set of "random" matrices each time is kind of brittle. |
With the CI passing and the comment to explain how to reproduce, does this look ok, @tkelman & @andreasnoack? |
Looks good to me. I''m puzzled by the the |
We had two
expm(x::Number)
methods defined.I moved some
Hessenberg
tests out ofdense.jl
toqr.jl
which is a more natural place for them.I added tests for
cholesky.jl
andmatmul.jl
.