Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc linalg tests #12870

Merged
merged 5 commits into from
Aug 31, 2015
Merged

Misc linalg tests #12870

merged 5 commits into from
Aug 31, 2015

Conversation

kshyatt
Copy link
Contributor

@kshyatt kshyatt commented Aug 29, 2015

We had two expm(x::Number) methods defined.

I moved some Hessenberg tests out of dense.jl to qr.jl which is a more natural place for them.

I added tests for cholesky.jl and matmul.jl.

@kshyatt kshyatt added test This change adds or pertains to unit tests linear algebra Linear algebra labels Aug 29, 2015
@kshyatt
Copy link
Contributor Author

kshyatt commented Aug 29, 2015

We have an unrelated OOM failure and something I don't understand on OSX. Weirdly enough, I ran this locally on OSX and it's fine?

I can reproduce on julia.mit.edu. When I remove the set srand seed things seem fine.

@kshyatt
Copy link
Contributor Author

kshyatt commented Aug 30, 2015

In the process of hunting I realized we were running the tests on the same matrices multiple times for no reason.

@tkelman
Copy link
Contributor

tkelman commented Aug 30, 2015

And running it multiple times was causing the failure?

@kshyatt
Copy link
Contributor Author

kshyatt commented Aug 30, 2015

I honestly have no idea. When I switched the random seeds, it went away. When I didn't preset a seed, it went away. I think this situation the linalg tests are in right now where we run with a specific set of "random" matrices each time is kind of brittle.

@kshyatt
Copy link
Contributor Author

kshyatt commented Aug 31, 2015

With the CI passing and the comment to explain how to reproduce, does this look ok, @tkelman & @andreasnoack?

@andreasnoack
Copy link
Member

Looks good to me. I''m puzzled by the the NaNs, but I don't feel like spending a day or two on tracking down an issue that has only been seen in a test for a specific seed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linear algebra Linear algebra test This change adds or pertains to unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants