Fix throwing of Pkg errors, add error-condition tests and fixes #13420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix MethodError from giving too many inputs to PkgError Add an unsatisfiable REQUIRES test Add tests for Pkg.pin error cases Adjust comment for issue number in a test
and add corresponding tests
tkelman
added
test
|
LGTM |
tkelman
added a commit
that referenced
this pull request
Oct 3, 2015
Fix throwing of Pkg errors, add error-condition tests and fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First two commits are #13419, I'll rebase them out after that's merged. The bug with the extraneous
.tmpis also present in 0.3 (and 0.2), so apparently no one has hit these error conditions and reported anything about it over the past 2 years.