Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

small enhancements to Task #13963

Merged
merged 3 commits into from
Nov 16, 2015
Merged

small enhancements to Task #13963

merged 3 commits into from
Nov 16, 2015

Commits on Nov 13, 2015

  1. avoid running finish_task inside of throw_internal 

    if throw_internal is running from the segv_handler, there might not be enough stack to run arbitrary functions
this change, therefore, makes stack overflow in tasks more reliable
    @vtjnash
    vtjnash committed Nov 13, 2015
    Configuration menu
    Copy the full SHA
    ca9d5e7 View commit details
    Browse the repository at this point in the history

  2. delete task->last and the :waiting state 

    the task->last field was unnecessary, and could result in a task staying alive in the gc unnecessarily

:runnable was almost equivalent to :waiting,
except that it might "be restarted unpredictably" (via the task->last field)
    @vtjnash
    vtjnash committed Nov 13, 2015
    2 Configuration menu
    Copy the full SHA
    ac02379 View commit details
    Browse the repository at this point in the history

  3. fix no COPY_STACKS option

    @vtjnash
    vtjnash committed Nov 13, 2015
    Configuration menu
    Copy the full SHA
    b238ac2 View commit details
    Browse the repository at this point in the history