Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back mention of local scoping with let blocks #14566

Closed
wants to merge 1 commit into from
Closed

Add back mention of local scoping with let blocks #14566

wants to merge 1 commit into from

Conversation

amellnik
Copy link
Contributor

@amellnik amellnik commented Jan 5, 2016

This was present in the 0.3 manual but went away in 0.4. Right now it's not mentioned in control flow either, and probably should be added in at some point, but this will involve a more-detailed addition to the docs.

This was present in the 0.3 manual but went away in 0.4.  Right now it's not mentioned in control flow either, and probably should be added in at some point, but this will involve a more-detailed addition to the docs.
@tkelman tkelman added the docs This change adds or pertains to documentation label Jan 5, 2016
@tkelman
Copy link
Contributor

tkelman commented Jan 5, 2016

It's generally preferred to open PR's against master first, they can be backported to the release branch later.

@amellnik
Copy link
Contributor Author

amellnik commented Jan 5, 2016

Whoops, I clicked on the "edit this" button on the doc site and didn't notice the version. Should this go into the 0.4.3 branch or 0.5?

@mauro3
Copy link
Contributor

mauro3 commented Jan 8, 2016

There is a big scope-manual update in PR #12146. There is a dedicated section on let-blocks, where this sentence could go: https://github.com/mauro3/julia/blob/abdfc24ac1a7acd67b474a1848758589d4613065/doc/manual/variables-and-scoping.rst#for-loops-and-comprehensions

@amellnik
Copy link
Contributor Author

amellnik commented Jan 8, 2016

Sounds good, I'll push there. Edit: actually, it looks like it's well handled there so I'll just close.

@amellnik amellnik closed this Jan 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This change adds or pertains to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants