Handle compressed AST in jl_local_in_linfo #15672
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This somehow shows up in threading build when `jl_static_eval` is called from `jl_get_unspecialized`.
|
I think this will be made unnecessary by jb/linear3 since the variable info is not part of the compressed code anymore |
|
That's right; on that branch this function doesn't exist any more. |
|
So is #15609 going to be ready soon? I'd like to make sure the threading build bot can pass since there's very frequent breakage on the threading build recently... |
|
Sounds good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This somehow shows up in threading build when
jl_static_evalis called fromjl_get_unspecialized.@vtjnash who had some comment about compressing and uncompressiong ast, to check if this is the right solution. =)