Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: Nullables as collections #16961

Merged
merged 10 commits into from
Dec 29, 2016
Merged

RFC: Nullables as collections #16961

merged 10 commits into from
Dec 29, 2016

Commits on Dec 27, 2016

  1. map and filter for Nullable 

    Filter, map for Nullable
    @TotalVerb
    TotalVerb committed Dec 27, 2016
    Configuration menu
    Copy the full SHA
    dbc4693 View commit details
    Browse the repository at this point in the history

  2. Scalar nullable broadcast 

    Nullsafe additions

Match optimal code for scalar-nullable broadcasts

--wip--

generated function
    @TotalVerb
    TotalVerb committed Dec 27, 2016
    Configuration menu
    Copy the full SHA
    aa655eb View commit details
    Browse the repository at this point in the history

  3. Vector broadcasting 

    Finishing touches

Clean up rebase issues

Fix rebase problems again

Address some comments

Extra line

Some more test cases

Use eltypes

more comments addressed

Replace powermod with muladd

Some more test cases
    @TotalVerb
    TotalVerb committed Dec 27, 2016
    Configuration menu
    Copy the full SHA
    d3e536c View commit details
    Browse the repository at this point in the history

  4. Deal with nullable scalar in more general way

    @TotalVerb
    TotalVerb committed Dec 27, 2016
    Configuration menu
    Copy the full SHA
    74ccb05 View commit details
    Browse the repository at this point in the history

  5. Simplify broadcast_indices methods

    @TotalVerb
    TotalVerb committed Dec 27, 2016
    Configuration menu
    Copy the full SHA
    06b8297 View commit details
    Browse the repository at this point in the history

  6. Docs for broadcast 

    NEWS

Add some more information to the nullable section
    @TotalVerb
    TotalVerb committed Dec 27, 2016
    Configuration menu
    Copy the full SHA
    242b333 View commit details
    Browse the repository at this point in the history

  7. Fix broadcast_type breakage

    @TotalVerb
    TotalVerb committed Dec 27, 2016
    Configuration menu
    Copy the full SHA
    5d5de20 View commit details
    Browse the repository at this point in the history

  8. Make tests test type

    @TotalVerb
    TotalVerb committed Dec 27, 2016
    Configuration menu
    Copy the full SHA
    2b7d457 View commit details
    Browse the repository at this point in the history

  9. Use Any and Array instead of custom types

    @TotalVerb
    TotalVerb committed Dec 27, 2016
    Configuration menu
    Copy the full SHA
    2f3d5cb View commit details
    Browse the repository at this point in the history

  10. Add note about what is broken

    @TotalVerb
    TotalVerb committed Dec 27, 2016
    Configuration menu
    Copy the full SHA
    aab9f05 View commit details
    Browse the repository at this point in the history