inline native Julia scalars encountered in f.(args...) AST #18202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -288,6 +288,8 @@ let identity = error, x = [1,2,3] | |||
| x .= 1 # make sure it goes to broadcast!(Base.identity, ...), not identity | |||
| @test x == [1,1,1] | |||
| end | |||
| # See issue #18176: | |||
| @test ((a,b,c) -> a+b+c).(1.0:2, 3, 4) == ((a,b,c) -> a+b+c).(1.0:2, 3.0, 4.0) == [8,9] | |||
There was a problem hiding this comment.
Given that this is also tested in #18200, instead of this, a test of the resulting expression after parsing would be more useful?
There was a problem hiding this comment.
I guess we could check the result of expand.
|
👍 to this, but I think it would be simpler to add an flisp-callable predicate to test whether a julia_value is a Number instead of adding a new type. |
|
@JeffBezanson, I don't think it would be shorter, but you're right that it may be cleaner. I'm working on an alternative PR. |
|
Closing in favor of #18205, which adds a new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an optimization, the "dot call" fusion does "inlining" of literal scalars, so that e.g.
f.(x,3)turns intobroadcast(x -> f(x,3), x)rather thanbroadcast(f, x, 3). This PR expands the range of scalars that are inlined to include JuliaNumberobjects in the AST (and could do the same forStringand some other types once #16966 is fixed … since it is just an optimization, it is okay if we aren't exhaustive).(As was observed in #18176, the parser actually ends up converting things like floating-point literals into Julia objects in the AST, so without this optimization they aren't inlined.)