Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for paths instead of path strings (replace #18375) #18514

Merged
merged 1 commit into from
Sep 15, 2016
Merged

Check for paths instead of path strings (replace #18375) #18514

merged 1 commit into from
Sep 15, 2016

Conversation

tkelman
Copy link
Contributor

@tkelman tkelman commented Sep 15, 2016

has a test this time

@tkelman tkelman added this to the 0.5.0 milestone Sep 15, 2016
@tkelman tkelman mentioned this pull request Sep 15, 2016
Closed
@tkelman tkelman added the compiler:precompilation Precompilation of modules label Sep 15, 2016
vtjnash
vtjnash approved these changes Sep 15, 2016
View reviewed changes
Copy link
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@tkelman tkelman merged commit d52a247 into master Sep 15, 2016
@tkelman tkelman deleted the jn/mdpradeep-18375 branch September 15, 2016 16:25
tkelman pushed a commit that referenced this pull request Sep 16, 2016
@mdpradeep @tkelman
Check for paths instead of path strings
cfbb42f 
(cherry picked from commit 788ce67)
ref #18514 and #18375
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash approved these changes

Assignees
No one assigned
Labels
compiler:precompilation Precompilation of modules
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tkelman @vtjnash @mdpradeep