Integrate test segfaults with the Testset scaffolding #19377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #19376 Also add utility tests `segfault` and `throw_error_exception` that do exactly what they sound like.
|
Sorry, I've been hella busy and not able to review. Will try to get to this tonight. |
kshyatt
approved these changes
Nov 24, 2016
Were these supposed to do anything or add tests somewhere that would actually run normally? Right now they're just orphan unused files. |
|
Yes, that's purposeful. You can use these to cause a segfault after a few
other tests by running something like "../julia runtests.jl bitarray spawn
util/segfault"
On Thu, Nov 24, 2016, 12:56 Tony Kelman ***@***.***> wrote:
Also add utility tests segfault and throw_error_exception that do exactly
what they sound like.
Were these supposed to do anything or add tests somewhere that would
actually run normally? Right now they're just orphan unused files.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#19377 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAH_aBp8x6CQgAEDkV-Np_biDOJTLNnfks5rBfnugaJpZM4K4n4X>
.
--
…-E
|
|
I don't think these should be checked in unless the test suite is going to use them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19376
Also add utility tests
segfaultandthrow_error_exceptionthat do exactlywhat they sound like.
I am most likely abusing the testset framework here, specifically this line is particularly bad, I think, where I'm co-opting the
Base.Test.Errortype and doing things like passing in an empty list instead of a backtrace, the testset name instead of the original expression, etc...I would have marked the test as
Brokeninstead ofErrorand seto_ts.anynonpasstotrue, but this gets clobbered byBase.Test.print_test_results()because that recalculateso_ts.anynonpass. This makes me think that we shouldn't be settingo_ts.anynonpassanywhere insidetest/runtests.jl.Pinging @kshyatt as you're the last person to touch this stuff and you probably know the "right" way to fix this. To test, run something like
./julia test/runtests.jl keywordargs inference dates/arithmetic util/segfault