Add doctest example for fill! #19422
Conversation
| 2×3 Array{Float64,2}: | ||
| 2.0 2.0 2.0 | ||
| 2.0 2.0 2.0 | ||
| ``` |
There was a problem hiding this comment.
This looks great! Two thoughts: Perhaps suppress the output of A = zeros(2,3) for compactness? Perhaps also add examples for the two trip hazards mentioned in the docstring? Best!
There was a problem hiding this comment.
I like showing the output of zeros just so people can see that fill! actually does something, especially since it's an early docstring in stdlib.
There was a problem hiding this comment.
I also looked into adding the examples for objrefs and eval-once but it makes the docstring super long. I think it's ok to leave those un-exampled for now.
There was a problem hiding this comment.
How about demos along these lines? Too long? Best!
julia> fill!(Vector{Int}(3), rand(Int))
3-element Array{Int64,1}:
-7884629895546034086
-7884629895546034086
-7884629895546034086
julia> a = [1, 1, 1]; A = fill!(Vector{Vector{Int}}(3), a); a[1] = 2; A
3-element Array{Array{Int64,1},1}:
[2,1,1]
[2,1,1]
[2,1,1]
There was a problem hiding this comment.
We don't want to use rand in doctests.
There was a problem hiding this comment.
Good catch! An alternative for that demo:
julia> x = 0; f() = (global x += 1; x); fill!(Vector{Int}(3), f())
1
1
1
kshyatt
force-pushed
the
ksh/filltest
branch
from
93372d3 to
fefbd3e
Compare
|
Added @Sacha0's great suggestions, this was a really easy rebase. |
* Add doctest example for fill! * Add more doctests
* Add doctest example for fill! * Add more doctests
No description provided.