Misc tests for issues fixed by jb/subtype #20097
Conversation
|
Unless they were related to an inference optimization, I think most of these should end up in subtype.jl #11840 isn't fixed. If that test is passing, it just means I need to update it |
| @test TypeVar(:T, Union{Int,Float64}) <: Union{Int,Float64} | ||
|
|
||
| # Issue #12721 | ||
| f12721{T<:Type{Int}}(::T) = true; |
|
I'll move the tests to subtype.jl. Unless I hear differently, I'll leave the 11840 tests as they are now but add the |
mauro3
force-pushed
the
m3/misc-jb-subtype-tests
branch
from
c2f5a97 to
c2a1fba
Compare
|
Updated. @vtjnash should give his "ok" before this gets merged. |
| @test Hermitian{Complex{Float64},Matrix{Complex{Float64}}} <: LinAlg.RealHermSymComplexHerm | ||
|
|
||
| # Issue #11803 | ||
| @test TypeVar(:T, Int) <: Int |
There was a problem hiding this comment.
I don't like this test. Manually constructing a TypeVar is not really a supposed operation. I wonder if it would be fair to say that:
(Tuple{T} where T<:Union{Int,Float64}) <: Tuple{Union{Int64,Float64}} tests the same thing. @JeffBezanson?
There was a problem hiding this comment.
I agree this test is invalid. Ideally it would be an error to pass anything with free type variables to <:. This file has plenty of tests that cover this sort of thing.
There was a problem hiding this comment.
Ok, let's just delete this test then.
mauro3
force-pushed
the
m3/misc-jb-subtype-tests
branch
from
c2a1fba to
42ca9d1
Compare
Added tests for issues JuliaLang#12580, JuliaLang#18348, JuliaLang#13165, JuliaLang#12721 For JuliaLang#11803 it was decidided that no tests are needed. Enabled extra tests for JuliaLang#11840, however, that isssue is not resolved yet but needs new tests triggering it.
mauro3
force-pushed
the
m3/misc-jb-subtype-tests
branch
from
42ca9d1 to
2cab8c0
Compare
Added misc tests referenced in #19998
Added tests for issues #12580, #18348, #13165, #11803, #12721. I placed those in
inference.jl, is that correct or should I move them?Enabled tests for #11840 (cc: @vtjnash)