Add a test throws an error by invalid subtyping in definition (#19414) #20548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshyatt
added
test
JeffBezanson
approved these changes
Apr 4, 2017
|
what happened to the commits that were testing for #20523? |
|
I don't know, but the code in #20523 is now rejected with an error, so it's not clear what to test (other than that error itself). |
|
The error's worth testing (and that's what wookay@6450075 / wookay@ad2a222 did), if that's the correct behavior that we want to keep. |
|
Aren't those tests identical to the one here? |
|
hi. I have updated the test with getting added the error message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, here's about the test for the invalid subtyping in definition.
#19414
#20523
thanks.