Use TypeVars in limit_type_depth in Unions in invariant position
#21192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For `isa(a, Const) && !isa(b, Const)`, `⊑` assumed `b` to be a type, leading to an error if `b` was a `PartialTypeVar`. Fixed by using `widenconst(b)`.
Using `Any` for depth-limited `Union` members is only correct in covariant position, otherwise a `TypeVar` has be be introduced.
JeffBezanson
approved these changes
Mar 28, 2017
|
There is a disabled test which needs to be enabled when #21191 is fixed. |
I belive |
|
Not if it crashes the system though, I presume? |
|
Ah right, from #21191 it seems that this would segfault. |
|
Indeed, or rather hit an assertion, but to the same effect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #20626 (comment) and https://discourse.julialang.org/t/strange-failure-in-v0-6/2911
Unfortunately, types were this make a difference seem to be the same where #21191 is hit, so until #21191 is fixed, this just changes the error produced...