Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase union stack size #21416

Merged
merged 1 commit into from
Apr 18, 2017
Merged

Increase union stack size #21416

merged 1 commit into from
Apr 18, 2017

Conversation

martinholters
Copy link
Member

Ref. #21191.

@martinholters
Increase union stack size
bdc1243 
This solves #21191 and similar issues, but there probably is an
underlying problem yet to be solved which makes such a large stack
necessary in the first place.
@martinholters martinholters mentioned this pull request Apr 17, 2017
Closed
@ararslan ararslan requested a review from JeffBezanson April 17, 2017 17:16
@ararslan ararslan added the types and dispatch Types, subtyping and method dispatch label Apr 17, 2017
@martinholters
Copy link
Member Author

AppVeyor failure in pkg test should be unrelated.

@JeffBezanson JeffBezanson merged commit 5ce0d7a into master Apr 18, 2017
@martinholters martinholters deleted the mh/union_stack_size branch April 18, 2017 15:58
tkelman
tkelman reviewed Apr 18, 2017
View reviewed changes
test/subtype.jl
T = Type{Tuple{V, I}} where V <: Vecs where I <: Ints
@testintersect(T, T, T)
test{V <: Vecs, I <: Ints}(a::Type{Tuple{V, I}}) = I
test{V <: Vecs, I <: Ints}(a::Type{Tuple{V, I}}) = I
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what are these two lines accomplishing / testing?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They're testing that the redefinition works, ref. #20103 (comment). But I acknowledge that would have been worth a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkelman tkelman tkelman left review comments

@JeffBezanson JeffBezanson JeffBezanson approved these changes

Assignees
No one assigned
Labels
types and dispatch Types, subtyping and method dispatch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@martinholters @JeffBezanson @tkelman @ararslan