Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify some methods for cholesky factorizations #21595

Merged
merged 1 commit into from
May 20, 2017

Conversation

fredrikekre
Copy link
Member

Started to look at implementing the suggestion made here and decided to start with this unifying of some duplicated methods. (similar to what was done in #21565 )

@@ -47,6 +44,7 @@ function CholeskyPivoted{T}(A::AbstractMatrix{T}, uplo::Char, piv::Vector{BlasIn
CholeskyPivoted{T,typeof(A)}(A, uplo, piv, rank, tol, info)
end

RealSymOrHerm{S} = Union{Symmetric{<:Real,S}, Hermitian{<:Any,S}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not reuse the definition in Symmetric.jl?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This? I thought that might not give the same type intersection but I guess it will?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess RealHermSymComplexHerm{<:Real,<:StridedMatrix} could be used for all methods in this file then? Worth adding a type alias for that here instead?

@ararslan ararslan added the linear algebra Linear algebra label Apr 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linear algebra Linear algebra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants