mach: use signal kqueue instead of sigwait #22041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Probably helps performance too, no? |
|
probably not |
|
:sadface: |
hm, we're going to have to workaround that before merging |
this may help avoid getting spurious sigwait notifications
vtjnash
force-pushed
the
jn/sigwait-mach
branch
from
4cdbecf to
38f834b
Compare
|
After this PR merged, |
|
List of recent builds: https://freebsdci.julialang.org/#/builders/1 |
|
@vtjnash, did you rerun CI across the board before merging this ten months later? |
vtjnash
added a commit
that referenced
this pull request
Dec 4, 2019
I am observing this value get set to EINTR sometimes on Linux. It is not generally supposed to do that (though not prohibited either). That is causing us to sometimes drop signals (usually SIGINT). Since we just need this code for Darwin (ref #17626, #22041, #20174), we can remove this from everywhere else.
vtjnash
added a commit
that referenced
this pull request
Dec 11, 2019
I am observing this value get set to EINTR sometimes on Linux. It is not generally supposed to do that (though not prohibited either). That is causing us to sometimes drop signals (usually SIGINT). Since we just need this code for Darwin (ref #17626, #22041, #20174), we can remove this from everywhere else.
KristofferC
pushed a commit
that referenced
this pull request
Apr 11, 2020
I am observing this value get set to EINTR sometimes on Linux. It is not generally supposed to do that (though not prohibited either). That is causing us to sometimes drop signals (usually SIGINT). Since we just need this code for Darwin (ref #17626, #22041, #20174), we can remove this from everywhere else.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this may help avoid getting spurious sigwait (InterruptException) notifications