Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC/WIP] Specify alignment of primitve types #22649

Closed
wants to merge 2 commits into from

Conversation

vchuravy
Copy link
Member

@vchuravy vchuravy commented Jul 1, 2017

This is my first time feeling my way around the parser code so any pointer would be welcomed. The goal is to allow users to specify alignments for bitstypes. My particular use-case comes after talking to @simonbyrne about Float128 support. I separated out the ABI changes for Float128 which will be part of a later PR.

I would want to make the alignment an optional value since their should be only a limited number of use-cases, any pointer how do to that in lisp?

@ararslan ararslan requested review from JeffBezanson and yuyichao July 1, 2017 06:06
@JeffBezanson
Copy link
Member

Cool. This looks basically right, it's just a matter of deciding exactly what syntax we want. For example we might want

primitive type Float128 <: AbstractFloat 128
    alignment=16
end

to leave more room for other features in the future.

@tkelman tkelman added needs docs Documentation for this change is required needs tests Unit tests are required for this change labels Jul 1, 2017
@vchuravy
Copy link
Member Author

vchuravy commented Jul 2, 2017

That sounds like an excellent idea. Any pointers how to do so without duplicating most of struct-def-expr- in julia-synatx.scm?

@vtjnash
Copy link
Member

vtjnash commented Jul 6, 2017

also fixes #20415

@vchuravy
Copy link
Member Author

Very stale.

@vchuravy vchuravy closed this Apr 26, 2023
@simonbyrne
Copy link
Contributor

I would still love a real Float128 (and perhaps Float80) one day...

@giordano giordano deleted the vc/aligned_bitstype branch March 12, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs docs Documentation for this change is required needs tests Unit tests are required for this change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants