Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use default system compiler version on Travis #22820

Merged
merged 1 commit into from
Jul 16, 2017
Merged

Use default system compiler version on Travis #22820

merged 1 commit into from
Jul 16, 2017

Conversation

tkelman
Copy link
Contributor

@tkelman tkelman commented Jul 15, 2017

gcc 4.8 now that we're using trusty
will be good to keep testing this while trusty is still widely used
since many other places are on gcc 5, 6, or 7 by now

[av skip]

@tkelman
Use default system compiler version on Travis
0e63ffc 
gcc 4.8 now that we're using trusty
will be good to keep testing this while trusty is still widely used
since many other places are on gcc 5, 6, or 7 by now

[av skip]
@iblislin
Copy link
Member

I just make buildbot recognize [bsd skip] or [skip bsd]. Please try it :)
(#20585 (comment))

@tkelman
Copy link
Contributor Author

tkelman commented Jul 15, 2017

@vchuravy gcc 4.8 is fine on linux w.r.t. #22189 and libatomic, right? Would we notice with a test failure if it wasn't? I don't think llvm or us are planning on dropping support for 4.8 for a while longer.

@ararslan ararslan added ci Continuous integration system:linux Affects only Linux labels Jul 15, 2017
@tkelman tkelman requested a review from yuyichao July 16, 2017 08:53
yuyichao
yuyichao approved these changes Jul 16, 2017
View reviewed changes
Copy link
Contributor

@yuyichao yuyichao left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as it passes on travis. We shouldn't be relying on any GCC 4.9+ features.

@tkelman
Copy link
Contributor Author

tkelman commented Jul 16, 2017

you mean shouldn't? thanks

@yuyichao
Copy link
Contributor

shouldn't

Right ..... ;-p

@tkelman tkelman merged commit 2641555 into master Jul 16, 2017
@tkelman tkelman deleted the tk/travis-gcc4 branch July 16, 2017 15:38
jeffwong pushed a commit to jeffwong/julia that referenced this pull request Jul 24, 2017
@tkelman @jeffwong
Use default system compiler version on Travis (JuliaLang#22820)
ec1158f 
gcc 4.8 now that we're using trusty
will be good to keep testing this while trusty is still widely used
since many other places are on gcc 5, 6, or 7 by now

[av skip]
yuyichao added a commit that referenced this pull request Sep 24, 2017
@yuyichao
Revert "Use default system compiler version on Travis (#22820)"
840247d 
This reverts commit 2641555.

GCC 4.8 miscompiles our LLVM pass.

Fix #23839
@yuyichao yuyichao mentioned this pull request Sep 24, 2017
Merged
JeffBezanson pushed a commit that referenced this pull request Sep 24, 2017
@yuyichao @JeffBezanson
Revert "Use default system compiler version on Travis (#22820)" (#23856)
0588ba4 
This reverts commit 2641555.

GCC 4.8 miscompiles our LLVM pass.

Fix #23839
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuyichao yuyichao yuyichao approved these changes

Assignees
No one assigned
Labels
ci Continuous integration system:linux Affects only Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tkelman @iblislin @yuyichao @ararslan