Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change several methods with StridedArray args to AbstractArray (#1276) #2455

Merged
merged 3 commits into from
Mar 4, 2013

Conversation

tshort
Copy link
Contributor

@tshort tshort commented Mar 4, 2013

Some of the "abstractified" methods were moved from array.jl to abstractarray.jl.

@pao
Copy link
Member

pao commented Mar 4, 2013

Build failure doesn't look to be your fault? I'll open a new issue.

@pao
Copy link
Member

pao commented Mar 4, 2013

Actually, I can't be sure now. It looks like it's failing to build the system image due to something in the delta between your two commits. Can you please verify locally?

@tshort
Copy link
Contributor Author

tshort commented Mar 4, 2013

I think that is my fault...

@tshort
Copy link
Contributor Author

tshort commented Mar 4, 2013

Hopefully, this latest change fixes the build.

I forgot to run make before restarting julia.

ViralBShah added a commit that referenced this pull request Mar 4, 2013
Change several methods with StridedArray args to AbstractArray (#1276)
@ViralBShah ViralBShah merged commit d443c81 into JuliaLang:master Mar 4, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants