Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate findn(x) in favor of find(!iszero, x), which now returns cartesian indices #25532

Merged
merged 2 commits into from
Jan 15, 2018
Merged

Deprecate findn(x) in favor of find(!iszero, x), which now returns cartesian indices #25532

merged 2 commits into from
Jan 15, 2018

Commits on Jan 13, 2018

  1. Fix find(::BitArray) return type and find() docstrings 

    The BitArray method was missed when changing the AbstractArray method to
return CartesianIndices for multidimensional arrays. Also fix the find(x)
docstring which was inconsistent with the find(f, x) one.
    @nalimilan
    nalimilan committed Jan 13, 2018
    Configuration menu
    Copy the full SHA
    5ec147b View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2018

  1. Deprecate findn(x) in favor of find(!iszero, x), which now returns ca… 

    …rtesian indices

Also make find(::Function, ::SparseMatrixCSC) slightly more efficient by avoiding an
intermediate allocation of index vectors.
    @nalimilan
    nalimilan committed Jan 14, 2018
    Configuration menu
    Copy the full SHA
    06eeaa3 View commit details
    Browse the repository at this point in the history