Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove Random.defaultRNG() #25650

Merged
merged 1 commit into from
Jan 21, 2018
Merged

remove Random.defaultRNG() #25650

merged 1 commit into from
Jan 21, 2018

Conversation

rfourquet
Copy link
Member

This function is an artifact of an intermediate state of
PR #24874, but is not needed anymore.

cf. #24874 (comment)

@rfourquet
remove Random.defaultRNG()
a80e80a 
This function is an artifact of an intermediate state of
PR #24874, but is not needed anymore.
@rfourquet rfourquet added the randomness Random number generation and the Random stdlib label Jan 20, 2018
ararslan
ararslan approved these changes Jan 20, 2018
View reviewed changes
Copy link
Member

@ararslan ararslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ViralBShah
Copy link
Member

Should we merge?

@ararslan ararslan merged commit c546f03 into master Jan 21, 2018
@ararslan ararslan deleted the rf/rand/delete-defaultRNG branch January 21, 2018 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ararslan ararslan ararslan approved these changes

Assignees
No one assigned
Labels
randomness Random number generation and the Random stdlib
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rfourquet @ViralBShah @ararslan