Audit iterator traits to make sure they're always called on types #25733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
base/iterators.jl
Outdated
| @@ -748,7 +748,7 @@ function IteratorEltype(::Type{ProductIterator{T}}) where {T<:Tuple} | |||
| IteratorEltype(I) == EltypeUnknown() ? EltypeUnknown() : IteratorEltype(P) | |||
| end | |||
|
|
|||
| eltype(P::ProductIterator) = _prod_eltype(P.iterators) | |||
| eltype(::Type{<:ProductIterator{I}}) where {I} = _prod_eltype((I.parameters...,)) | |||
There was a problem hiding this comment.
Ideally these should be rewritten to use tuple_type_head.
base/reinterpretarray.jl
Outdated
| @@ -35,7 +35,7 @@ end | |||
|
|
|||
| parent(a::ReinterpretArray) = a.parent | |||
|
|
|||
| eltype(a::ReinterpretArray{T}) where {T} = T | |||
| eltype(a::Type{<:ReinterpretArray{T}}) where {T} = T | |||
There was a problem hiding this comment.
Unnecessary; should be inherited from AbstractArray.
stdlib/Test/src/Test.jl
Outdated
| @@ -1456,6 +1456,7 @@ for (G, A) in ((GenericSet, AbstractSet), | |||
| Base.$f(s::$G) = $f(s.s) | |||
| end | |||
| end | |||
| Base.eltype(::Type{<:G}) = eltype(fieldtype(G, :s)) | |||
There was a problem hiding this comment.
Also covered by AbstractSet I think.
The iterator wrappers assume that eltype is called on the type of the wrapped iterator, not the value itself, so all objects that implement these traits need to do so. Audit all of them in base and make sure that's the case.
|
This forgot to update the docstring |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The iterator wrappers assume that eltype is called on the type of
the wrapped iterator, not the value itself, so all objects that
implement these traits need to do so. Audit all of them in base
and make sure that's the case.