absorb repmat into repeat and deprecate it
#26039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
added
arrays
StefanKarpinski
approved these changes
Feb 13, 2018
mbauman
approved these changes
Feb 13, 2018
base/abstractarraymath.jl
Outdated
| @@ -241,14 +241,13 @@ end | |||
| ## Other array functions ## | |||
|
|
|||
| """ | |||
| repmat(A, m::Integer, n::Integer=1) | |||
| repeat(A, counts::Integer...) | |||
There was a problem hiding this comment.
Add the constraint that A::AbstractArray?
JeffBezanson
force-pushed
the
jb/repeat
branch
from
630e9b4
to
7f22e66
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is a pretty clear improvement, since
repmatonly implements a very small number of special cases ofrepeat.I added the signature
repeat(array, n, m, ...)since (1) this is consistent with other repeat methods likerepeat(str, n)and (2) this makes it easier to deprecaterepmatsincerepeat(A, outer=(n,m))is a bit verbose. Then I hooked uprepeat(A, outer=...)to call the optimized kernels we have forrepmatwhen possible.