Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate defaulting to scalar in broadcast (take 2) #26435

Merged
merged 3 commits into from
Mar 22, 2018
Merged

Deprecate defaulting to scalar in broadcast (take 2) #26435

merged 3 commits into from
Mar 22, 2018
+118 −52

Commits on Mar 21, 2018

  1. fixup Pkg3 broadcasting over iterables

    @mbauman
    mbauman committed Mar 21, 2018
    2 Configuration menu
    Copy the full SHA
    e17a2a2 View commit details
    Browse the repository at this point in the history

  2. Default to iterating over broadcast arguments 

    Broadcast now calls a special helper function, `broadcastable`, on each argument. It ensures that the arguments support indexing and have a shape, or otherwise have defined a custom `BroadcastStyle`.
    @mbauman
    mbauman committed Mar 21, 2018
    Configuration menu
    Copy the full SHA
    7591c44 View commit details
    Browse the repository at this point in the history

  3. Add a deprecation and comment out future behavior. Add NEWS and docs.

    @mbauman
    mbauman committed Mar 21, 2018
    Configuration menu
    Copy the full SHA
    54f54a5 View commit details
    Browse the repository at this point in the history